Expose method to reset translate settings.

ios/web_view/public/cwv_translation_controller.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_CONTROLLER_H
 #define IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_CONTROLLER_H
 
 #import <Foundation/Foundation.h>
 
 #import "cwv_export.h"
@@ skipping 34 matching lines @@
 @interface CWVTranslationController : NSObject
 
 // Delegate to receive translation callbacks.
 @property(nullable, nonatomic, weak) id<CWVTranslationControllerDelegate>
     delegate;
 
 // The set of supported languages for translation.
 @property(nonatomic, readonly)
     NSSet<CWVTranslationLanguage*>* supportedLanguages;
 
+// Resets all translation policies to CWVTranslationPolicyAsk.
+// Only resets non-incognito settings.
++ (void)resetTranslationPolicies;
+
 // Begins translation on the current page from |sourceLanguage| to
 // |targetLanguage|. These language parameters must be chosen from
 // |supportedLanguages|. Set |userInitiated| to YES if translation
 // is a result of explicit user action. |userInitiated| will be
 // passed along to the CWVTranslationControllerDelegate methods.
 // Results in a No-op if there is no current page.
 - (void)translatePageFromLanguage:(CWVTranslationLanguage*)sourceLanguage
                        toLanguage:(CWVTranslationLanguage*)targetLanguage
                     userInitiated:(BOOL)userInitiated;
 
 // Reverts any translations done back to the original page language.
 // Note that the original page language may be different from |sourceLanguage|
 // passed to |translatePageFromLanguage:toLanguage:userInitiated:| above.
 // Results in No-op if the page was never translated.
 - (void)revertTranslation;
 
 // Sets or retrieves translation policies associated with a specified language.
 // |pageLanguage| should be the language code of the language.
+// Asserts in incognito mode.

[Hiroshi Ichikawa, 2017/07/10 06:22:26]

Should be "Causes assertion failure in incognito mode", or maybe you can just
say "Not supported in incognito mode".

The current sentence can be read as "Asserts that it is in incognito mode" which
means opposite.

[Eugene But (OOO till 7-30), 2017/07/10 16:17:43]

What is the value of asserting in Incognito mode? If apps want to be able to set
policies in incognito mode we should allow that in API. I think it should be up
to application developer to decide whether or not they want to allow translation
policies for Incognito. WDYT?

[jzw1, 2017/07/10 18:51:40]

I think it makes sense to not share translate preferences between incognito and
non-incognito, even though Chrome iOS shares them. If we want to go with Chrome
iOS route, we'd have to refactor browser states to have a parent child
relationship between non-incognito and incognito browser states.

I'd want to discourage setting policies for incognito because they are only
stored in-memory, and I don't really see value in letting users store temporary
values.

 - (void)setTranslationPolicy:(CWVTranslationPolicy*)policy
              forPageLanguage:(CWVTranslationLanguage*)pageLanguage;
 - (CWVTranslationPolicy*)translationPolicyForPageLanguage:
     (CWVTranslationLanguage*)pageLanguage;
 
 // Sets or retrieves translation policies associated with a specified page.
 // |pageHost| should be the hostname of the website. Must not be empty.
+// Asserts in incognito mode.

[Hiroshi Ichikawa, 2017/07/10 06:22:26]

Ditto.

[jzw1, 2017/07/10 18:51:40]

Done.

 - (void)setTranslationPolicy:(CWVTranslationPolicy*)policy
                  forPageHost:(NSString*)pageHost;
 - (CWVTranslationPolicy*)translationPolicyForPageHost:(NSString*)pageHost;
 
 @end
 
 NS_ASSUME_NONNULL_END
 
 #endif  // IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_CONTROLLER_H