Fix and re-enable some browser focus interactive ui tests.

Fix and re-enable some browser focus interactive ui tests.

Fix FocusTraversal[OnInterstitial] except *OnInterstitial on Mac :(
Fix InterstitialFocus and FindFocusTest.

Add a TestFocusTraversal helper function consolidated from tests.
Simplify TestInterstitialPage and add a WaitForInterstitial helper.
Move test server init to a common SetUpOnMainThread.
Remove unnecessary helpers and includes.

TODO(followup): Fix more tests!
TODO(followup): s/DisableFindBarAnimationsDuringTesting/ScopedAnimationDurationScaleMode/?

BUG=60973, 62544, 67301, 81451, 109770, 163931
TEST=Automated tests work and stay enabled...
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272259

[msw, 2014-05-21 23:57:38]

Hey Scott, please take a look; thanks!
(review from those CC'ed is welcome)

[sky, 2014-05-22 04:13:35]

https://codereview.chromium.org/296523002/diff/140001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_focus_uitest.cc (right):

https://codereview.chromium.org/296523002/diff/140001/chrome/browser/ui/brows...
chrome/browser/ui/browser_focus_uitest.cc:417:
EXPECT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
Shouldn't this be an ASSERT? Is there any point in continuing if focus isn't
here?

https://codereview.chromium.org/296523002/diff/140001/chrome/browser/ui/brows...
chrome/browser/ui/browser_focus_uitest.cc:421:
TestFocusTraversal(tab->GetRenderViewHost(), false);
Do you want to wrap these in EXPECT_NO_FATAL_FAILURE?

[msw, 2014-05-22 04:46:53]

https://codereview.chromium.org/296523002/diff/140001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_focus_uitest.cc (right):

https://codereview.chromium.org/296523002/diff/140001/chrome/browser/ui/brows...
chrome/browser/ui/browser_focus_uitest.cc:417:
EXPECT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
On 2014/05/22 04:13:35, sky wrote:
> Shouldn't this be an ASSERT? Is there any point in continuing if focus isn't
> here?

Actually, the meat of the test is the focus traversals below, which are
dependent upon the omnibox being initially focused by the FocusLocationBar call
below. A failure there is what would really make the rest of the test pointless,
so I changed the first CHECK in TestFocusTraversal to an ASSERT.

https://codereview.chromium.org/296523002/diff/140001/chrome/browser/ui/brows...
chrome/browser/ui/browser_focus_uitest.cc:421:
TestFocusTraversal(tab->GetRenderViewHost(), false);
On 2014/05/22 04:13:35, sky wrote:
> Do you want to wrap these in EXPECT_NO_FATAL_FAILURE?

Done.

[sky, 2014-05-22 14:01:36]

LGTM

[msw, 2014-05-22 14:54:05]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-05-22 14:55:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/296523002/160001

[commit-bot: I haz the power, 2014-05-22 19:00:27]

Change committed as 272259

[tapted, 2014-05-23 06:12:12]

A revert of this CL has been created in
https://codereview.chromium.org/299703018/ by tapted@chromium.org.

The reason for reverting is: Tests failing on WinXP waterfall bot:

2 tests timed out:
    BrowserFocusTest.FocusTraversal
    BrowserFocusTest.FocusTraversalOnInterstitial

Starting

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds....