components/contextual_suggestions/BUILD.gn - Issue 2965173002: Add ContextualSuggestionsService to Omnibox

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/contextual_suggestions/BUILD.gn

Issue 2965173002: Add ContextualSuggestionsService to Omnibox (Closed)

Patch Set: Initial component creation Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/autocomplete/contextual_suggestions_service_factory.h ('K') | « chrome/browser/autocomplete/contextual_suggestions_service_factory.cc ('k') | components/contextual_suggestions/DEPS » ('j') | components/contextual_suggestions/DEPS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.
	Marc Treib 2017/07/06 08:32:20 2017 2017 gcomanici 2017/07/06 15:34:17 Done. Show quoted text On 2017/07/06 08:32:20, Marc Treib wrote: > 2017 Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 static_library("contextual_suggestions") {

	6 sources = [

	7 "contextual_suggestions_service.cc",

	8 "contextual_suggestions_service.h",

	9 ]

	10 public_deps = [

	11 "//net",

	12 "//url",

	13 ]

	14 deps = [

	15 "//base",

	16 "//components/data_use_measurement/core",

	17 "//components/keyed_service/core",

	18 "//components/search_engines",

	19 "//components/signin/core/browser",

	20 "//components/variations/net",

	21 "//google_apis",
	Marc Treib 2017/07/06 08:32:20 Are all these actually needed (yet)? Are all these actually needed (yet)? gcomanici 2017/07/06 15:34:17 I am not very familiar with BUILD.gn files, so I a Show quoted text On 2017/07/06 08:32:20, Marc Treib wrote: > Are all these actually needed (yet)? I am not very familiar with BUILD.gn files, so I added these dependencies based on the imports that I made in the sources. Is there a better approach at making sure that this list is as small as possible? If there's a link you are aware of, please share. Thanks! Marc Treib 2017/07/06 16:02:45 No, I'm not aware of a better approach. I was most Show quoted text On 2017/07/06 15:34:17, gcomanici wrote: > On 2017/07/06 08:32:20, Marc Treib wrote: > > Are all these actually needed (yet)? > > I am not very familiar with BUILD.gn files, so I added these dependencies based > on the imports that I made in the sources. Is there a better approach at making > sure that this list is as small as possible? If there's a link you are aware of, > please share. Thanks! No, I'm not aware of a better approach. I was mostly checking that these weren't just copied from components/suggestions :)
	22 ]

	23 }

OLD	NEW