components/omnibox/browser/DEPS - Issue 2965173002: Add ContextualSuggestionsService to Omnibox

Side by Side Diff: components/omnibox/browser/DEPS

Issue 2965173002: Add ContextualSuggestionsService to Omnibox (Closed)

Patch Set: Move contextual suggestions service to c/o/b Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/autocomplete/contextual_suggestions_service_factory.cc ('K') | « components/omnibox/browser/BUILD.gn ('k') | components/omnibox/browser/autocomplete_provider_client.h » ('j') | components/omnibox/browser/contextual_suggestions_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/bookmarks/browser",	2 "+components/bookmarks/browser",

3 "+components/bookmarks/test",	3 "+components/bookmarks/test",

	4 "+components/contextual_suggestions",
	Mark P 2017/07/17 23:36:12 This isn't necessary anymore. This isn't necessary anymore.
4 "+components/data_use_measurement/core",	5 "+components/data_use_measurement/core",

5 "+components/grit/components_scaled_resources.h",	6 "+components/grit/components_scaled_resources.h",

6 "+components/history/core/browser",	7 "+components/history/core/browser",

7 "+components/history/core/test",	8 "+components/history/core/test",

8 "+components/keyed_service/core",	9 "+components/keyed_service/core",

9 "+components/metrics",	10 "+components/metrics",

10 "+components/open_from_clipboard",	11 "+components/open_from_clipboard",

11 "+components/physical_web/data_source",	12 "+components/physical_web/data_source",

12 "+components/pref_registry",	13 "+components/pref_registry",

13 "+components/prefs",	14 "+components/prefs",

14 "+components/query_parser",	15 "+components/query_parser",

15 "+components/search",	16 "+components/search",

16 "+components/search_engines",	17 "+components/search_engines",

17 "+components/sessions",	18 "+components/sessions",

	19 "+components/signin/core/browser",
	Mark P 2017/07/17 23:36:12 I'm not sure it's okay to include components/.../b I'm not sure it's okay to include components/.../browser stuffy in this non-browser component. I think it is because this component is basically only building a "browser" library plus some tests, but I'd like someone who understands what layers we're supposed to have to comment. blundell 2017/07/18 15:21:14 This should be absolutely fine unless there's some Show quoted text On 2017/07/17 23:36:12, Mark P wrote: > I'm not sure it's okay to include components/.../browser stuffy in this > non-browser component. I think it is because this component is basically only > building a "browser" library plus some tests, but I'd like someone who > understands what layers we're supposed to have to comment. This should be absolutely fine unless there's something I'm missing. Why do you call //components/omnibox/browser a non-browser component? Mark P 2017/07/18 19:11:28 No, you're not missing something. I'm missing som Show quoted text On 2017/07/18 15:21:14, blundell wrote: > On 2017/07/17 23:36:12, Mark P wrote: > > I'm not sure it's okay to include components/.../browser stuffy in this > > non-browser component. I think it is because this component is basically only > > building a "browser" library plus some tests, but I'd like someone who > > understands what layers we're supposed to have to comment. > > This should be absolutely fine unless there's something I'm missing. Why do you > call //components/omnibox/browser a non-browser component? No, you're not missing something. I'm missing something ... :-) (I missed the BROWSER part of the filename for components/omnibox/browser/DEPS.)
18 "+components/strings/grit/components_strings.h",	20 "+components/strings/grit/components_strings.h",

19 "+components/toolbar",	21 "+components/toolbar",

20 "+components/url_formatter",	22 "+components/url_formatter",

21 "+components/variations",	23 "+components/variations",

22 "+extensions/common/constants.h",	24 "+extensions/common/constants.h",

23 "+net",	25 "+net",

24 "+sql",	26 "+sql",

25 "+third_party/protobuf/src/google",	27 "+third_party/protobuf/src/google",

26 "+third_party/skia",	28 "+third_party/skia",

27 "+ui/base",	29 "+ui/base",

28 "+ui/gfx",	30 "+ui/gfx",

29 "+ui/vector_icons",	31 "+ui/vector_icons",

30 "+url",	32 "+url",

31 ]	33 ]

OLD	NEW