| Index: chrome/browser/extensions/api/storage/syncable_settings_storage.cc
|
| diff --git a/chrome/browser/extensions/api/storage/syncable_settings_storage.cc b/chrome/browser/extensions/api/storage/syncable_settings_storage.cc
|
| index e6668ec82948ffed5059e6d7554a575f81d97010..68c3937b48d0e6a8acd58ed7a8961dedefaa248d 100644
|
| --- a/chrome/browser/extensions/api/storage/syncable_settings_storage.cc
|
| +++ b/chrome/browser/extensions/api/storage/syncable_settings_storage.cc
|
| @@ -12,11 +12,9 @@
|
| #include "chrome/browser/extensions/api/storage/settings_sync_util.h"
|
| #include "components/sync/model/sync_data.h"
|
| #include "components/sync/protocol/extension_setting_specifics.pb.h"
|
| -#include "content/public/browser/browser_thread.h"
|
| +#include "extensions/browser/api/storage/backend_task_runner.h"
|
| #include "extensions/browser/api/storage/settings_namespace.h"
|
|
|
| -using content::BrowserThread;
|
| -
|
| namespace extensions {
|
|
|
| SyncableSettingsStorage::SyncableSettingsStorage(
|
| @@ -31,26 +29,26 @@ SyncableSettingsStorage::SyncableSettingsStorage(
|
| delegate_(delegate),
|
| sync_type_(sync_type),
|
| flare_(flare) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| }
|
|
|
| SyncableSettingsStorage::~SyncableSettingsStorage() {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| }
|
|
|
| size_t SyncableSettingsStorage::GetBytesInUse(const std::string& key) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| return delegate_->GetBytesInUse(key);
|
| }
|
|
|
| size_t SyncableSettingsStorage::GetBytesInUse(
|
| const std::vector<std::string>& keys) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| return delegate_->GetBytesInUse(keys);
|
| }
|
|
|
| size_t SyncableSettingsStorage::GetBytesInUse() {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| return delegate_->GetBytesInUse();
|
| }
|
|
|
| @@ -70,24 +68,24 @@ T SyncableSettingsStorage::HandleResult(T result) {
|
|
|
| ValueStore::ReadResult SyncableSettingsStorage::Get(
|
| const std::string& key) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| return HandleResult(delegate_->Get(key));
|
| }
|
|
|
| ValueStore::ReadResult SyncableSettingsStorage::Get(
|
| const std::vector<std::string>& keys) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| return HandleResult(delegate_->Get(keys));
|
| }
|
|
|
| ValueStore::ReadResult SyncableSettingsStorage::Get() {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| return HandleResult(delegate_->Get());
|
| }
|
|
|
| ValueStore::WriteResult SyncableSettingsStorage::Set(
|
| WriteOptions options, const std::string& key, const base::Value& value) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| WriteResult result = HandleResult(delegate_->Set(options, key, value));
|
| if (!result->status().ok())
|
| return result;
|
| @@ -97,7 +95,7 @@ ValueStore::WriteResult SyncableSettingsStorage::Set(
|
|
|
| ValueStore::WriteResult SyncableSettingsStorage::Set(
|
| WriteOptions options, const base::DictionaryValue& values) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| WriteResult result = HandleResult(delegate_->Set(options, values));
|
| if (!result->status().ok())
|
| return result;
|
| @@ -107,7 +105,7 @@ ValueStore::WriteResult SyncableSettingsStorage::Set(
|
|
|
| ValueStore::WriteResult SyncableSettingsStorage::Remove(
|
| const std::string& key) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| WriteResult result = HandleResult(delegate_->Remove(key));
|
| if (!result->status().ok())
|
| return result;
|
| @@ -117,7 +115,7 @@ ValueStore::WriteResult SyncableSettingsStorage::Remove(
|
|
|
| ValueStore::WriteResult SyncableSettingsStorage::Remove(
|
| const std::vector<std::string>& keys) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| WriteResult result = HandleResult(delegate_->Remove(keys));
|
| if (!result->status().ok())
|
| return result;
|
| @@ -126,7 +124,7 @@ ValueStore::WriteResult SyncableSettingsStorage::Remove(
|
| }
|
|
|
| ValueStore::WriteResult SyncableSettingsStorage::Clear() {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| WriteResult result = HandleResult(delegate_->Clear());
|
| if (!result->status().ok())
|
| return result;
|
| @@ -156,7 +154,7 @@ void SyncableSettingsStorage::SyncResultIfEnabled(
|
| syncer::SyncError SyncableSettingsStorage::StartSyncing(
|
| std::unique_ptr<base::DictionaryValue> sync_state,
|
| std::unique_ptr<SettingsSyncProcessor> sync_processor) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| DCHECK(sync_state);
|
| DCHECK(!sync_processor_.get());
|
|
|
| @@ -182,7 +180,7 @@ syncer::SyncError SyncableSettingsStorage::StartSyncing(
|
|
|
| syncer::SyncError SyncableSettingsStorage::SendLocalSettingsToSync(
|
| std::unique_ptr<base::DictionaryValue> local_state) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
|
|
| if (local_state->empty())
|
| return syncer::SyncError();
|
| @@ -207,7 +205,7 @@ syncer::SyncError SyncableSettingsStorage::SendLocalSettingsToSync(
|
| syncer::SyncError SyncableSettingsStorage::OverwriteLocalSettingsWithSync(
|
| std::unique_ptr<base::DictionaryValue> sync_state,
|
| std::unique_ptr<base::DictionaryValue> local_state) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| // This is implemented by building up a list of sync changes then sending
|
| // those to ProcessSyncChanges. This generates events like onStorageChanged.
|
| std::unique_ptr<SettingSyncDataList> changes(new SettingSyncDataList());
|
| @@ -249,13 +247,13 @@ syncer::SyncError SyncableSettingsStorage::OverwriteLocalSettingsWithSync(
|
| }
|
|
|
| void SyncableSettingsStorage::StopSyncing() {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| sync_processor_.reset();
|
| }
|
|
|
| syncer::SyncError SyncableSettingsStorage::ProcessSyncChanges(
|
| std::unique_ptr<SettingSyncDataList> sync_changes) {
|
| - DCHECK_CURRENTLY_ON(BrowserThread::FILE);
|
| + DCHECK(IsOnBackendSequence());
|
| DCHECK(!sync_changes->empty()) << "No sync changes for " << extension_id_;
|
|
|
| if (!sync_processor_.get()) {
|
|
|