Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2965133003: Move findElementsByName() into shared analyzer/element_search.dart file. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move findElementsByName() into shared analyzer/element_search.dart file. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/19265a82b4d242f5ba949a1ebeb5a79ea0f0a3ce

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -76 lines) Patch
M pkg/analysis_server/test/plugin/protocol_dart_test.dart View 3 chunks +1 line, -24 lines 0 comments Download
A pkg/analyzer/lib/src/generated/testing/element_search.dart View 1 chunk +26 lines, -0 lines 1 comment Download
M pkg/analyzer/test/src/dart/analysis/search_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/utils.dart View 2 chunks +3 lines, -27 lines 0 comments Download
M pkg/analyzer_plugin/test/support/abstract_context.dart View 4 chunks +1 line, -24 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-06 18:38:35 UTC) #1
Brian Wilkerson
lgtm, thanks! https://codereview.chromium.org/2965133003/diff/1/pkg/analyzer/lib/src/generated/testing/element_search.dart File pkg/analyzer/lib/src/generated/testing/element_search.dart (right): https://codereview.chromium.org/2965133003/diff/1/pkg/analyzer/lib/src/generated/testing/element_search.dart#newcode1 pkg/analyzer/lib/src/generated/testing/element_search.dart:1: import 'package:analyzer/dart/ast/ast.dart'; Missing copyright.
3 years, 5 months ago (2017-07-06 18:42:29 UTC) #2
scheglov
3 years, 5 months ago (2017-07-06 18:51:23 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
19265a82b4d242f5ba949a1ebeb5a79ea0f0a3ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698