Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 296513022: Temporarily disable Alpha shaped windows (Closed)

Created:
6 years, 7 months ago by garykac
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Temporarily disable Alpha shaped windows Due to bugs with scaling and handling NULL regions. BUG=376532 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
garykac
6 years, 7 months ago (2014-05-23 19:03:25 UTC) #1
Wez
nit: Suggest "temporarily disable" in the CL description. Given that we're reverting alpha shaping in ...
6 years, 7 months ago (2014-05-23 19:09:10 UTC) #2
Wez
lgtm
6 years, 7 months ago (2014-05-23 19:09:36 UTC) #3
garykac
On 2014/05/23 19:09:10, Wez wrote: > nit: Suggest "temporarily disable" in the CL description. Done. ...
6 years, 7 months ago (2014-05-23 19:55:13 UTC) #4
Zachary Kuznia
lgtm
6 years, 7 months ago (2014-05-23 20:11:18 UTC) #5
Wez
The CQ bit was checked by wez@chromium.org
6 years, 7 months ago (2014-05-23 20:23:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/296513022/1
6 years, 7 months ago (2014-05-23 20:24:31 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 00:36:38 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 00:42:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69624)
6 years, 7 months ago (2014-05-24 00:42:45 UTC) #10
Wez
+benwells for OWNERS
6 years, 7 months ago (2014-05-24 00:45:28 UTC) #11
benwells
lgtm
6 years, 7 months ago (2014-05-26 01:44:20 UTC) #12
Wez
The CQ bit was checked by wez@chromium.org
6 years, 7 months ago (2014-05-26 01:45:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/296513022/1
6 years, 7 months ago (2014-05-26 01:45:44 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 04:10:46 UTC) #15
Message was sent while issue was closed.
Change committed as 272779

Powered by Google App Engine
This is Rietveld 408576698