Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issue 296513020: Add OWNERS for //components/test/data/password_manager (Closed)

Created:
6 years, 7 months ago by vabr (Chromium)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, Patrick Dubroy, Garrett Casto
Visibility:
Public.

Description

Add OWNERS for //components/test/data/password_manager NOTRY=true BUG=369521 Committed manually as http://src.chromium.org/viewvc/chrome?revision=272457&view=revision

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A + components/test/data/password_manager/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vabr (Chromium)
isherman, gcasto, dubroy: FYI, let me know if you want to change anything Hi Jochen, ...
6 years, 7 months ago (2014-05-23 07:16:44 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-23 07:40:42 UTC) #2
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 7 months ago (2014-05-23 07:41:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/296513020/1
6 years, 7 months ago (2014-05-23 07:42:11 UTC) #4
vabr (Chromium)
The CQ bit was unchecked by vabr@chromium.org
6 years, 7 months ago (2014-05-23 09:47:12 UTC) #5
vabr (Chromium)
6 years, 7 months ago (2014-05-23 09:55:04 UTC) #6
I had some problems with dcommitting this, and I hit Ctrl+C during the dcommit.
Bad idea, I know now. :(
The revision landed as
http://src.chromium.org/viewvc/chrome?revision=272457&view=revision, and looks
fine.
I'll update the description here and the bugreport manually, as it seems that's
what the script did not manage to do before the kill.

Powered by Google App Engine
This is Rietveld 408576698