Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 296513010: Remove RenderViewImpl::didActivateCompositor (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Remove RenderViewImpl::didActivateCompositor Everything is composited, so just move this code into initialization. R=piman@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273695

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move to RenderViewImpl::Initialize #

Patch Set 3 : Add back in missing code for null render thread #

Patch Set 4 : Fix incorrect devtools early out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M content/renderer/render_view_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 2 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
enne (OOO)
I apparently didn't clean this up enough in https://codereview.chromium.org/288633002/
6 years, 7 months ago (2014-05-21 22:53:56 UTC) #1
piman
https://codereview.chromium.org/296513010/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/296513010/diff/1/content/renderer/render_view_impl.cc#newcode739 content/renderer/render_view_impl.cc:739: compositor_->GetInputHandler(), Do we have compositor_ this early? I thought ...
6 years, 7 months ago (2014-05-22 00:12:24 UTC) #2
enne (OOO)
https://codereview.chromium.org/296513010/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/296513010/diff/1/content/renderer/render_view_impl.cc#newcode739 content/renderer/render_view_impl.cc:739: compositor_->GetInputHandler(), On 2014/05/22 00:12:24, piman OOO back 2014-6-09 wrote: ...
6 years, 7 months ago (2014-05-27 20:40:32 UTC) #3
piman
lgtm
6 years, 7 months ago (2014-05-28 10:56:29 UTC) #4
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 6 months ago (2014-05-28 17:14:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/296513010/20001
6 years, 6 months ago (2014-05-28 17:15:33 UTC) #6
enne (OOO)
The CQ bit was unchecked by enne@chromium.org
6 years, 6 months ago (2014-05-28 17:37:51 UTC) #7
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 6 months ago (2014-05-28 18:07:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/296513010/40001
6 years, 6 months ago (2014-05-28 18:08:36 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 21:57:22 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 22:42:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157769)
6 years, 6 months ago (2014-05-28 22:42:18 UTC) #12
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 6 months ago (2014-05-29 20:14:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/296513010/60001
6 years, 6 months ago (2014-05-29 20:16:51 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 00:41:47 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 01:51:19 UTC) #16
Message was sent while issue was closed.
Change committed as 273695

Powered by Google App Engine
This is Rietveld 408576698