Issue 296513002: Hook up the blink platform GN file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296513002: Hook up the blink platform GN file. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
Nico, eseidel

CC:
chromium-reviews, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Hook up the blink platform GN file. Hooks up the blink GN build to the main GN build. Android is currently disabled (some dependencies are not complete yet). R=eseidel@chromium.org, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271707

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	BUILD.gn	View		3 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

eseidel

lgtm Please just CC thakis on build-system changes to Blink and feel free to TBR ...

6 years, 7 months ago (2014-05-19 18:03:31 UTC) #2

eseidel

I'm happy to review your changes, I just don't want to slow you down. :)

6 years, 7 months ago (2014-05-19 18:04:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/296513002/1

6 years, 7 months ago (2014-05-20 17:38:07 UTC) #6

brettw

6 years, 7 months ago (2014-05-20 18:01:01 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r271707 (presubmit successful).