Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2965123002: Fix greatest/least closure computation when there are multiple `?`s. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix greatest/least closure computation when there are multiple `?`s. Also add both a unit test and a strong mode inference test case. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d8a6cfa4c1fb8e3f98006e9cf3d8103a2f788f42

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-07-05 21:25:47 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-05 21:37:16 UTC) #3
Paul Berry
3 years, 5 months ago (2017-07-06 19:13:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8a6cfa4c1fb8e3f98006e9cf3d8103a2f788f42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698