Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2965053002: Fix for types of function-typed parameters in reified type of MethodElement. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for types of function-typed parameters in reified type of MethodElement. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e93566189f638f9e0349c794d7bcfef95e5b64a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-05 17:25:22 UTC) #1
Brian Wilkerson
Should we have a test for this? Other than that, lgtm.
3 years, 5 months ago (2017-07-05 17:28:18 UTC) #2
scheglov
On 2017/07/05 17:28:18, Brian Wilkerson wrote: > Should we have a test for this? Other ...
3 years, 5 months ago (2017-07-05 17:32:22 UTC) #3
scheglov
3 years, 5 months ago (2017-07-05 17:32:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e93566189f638f9e0349c794d7bcfef95e5b64a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698