Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 296503003: Remove channel restrictions for the CAEDT promo. (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove channel restrictions for the CAEDT promo. Enable the promotion for the Chrome Apps and Extensions Developer Tool in all channels. BUG=365219 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Devlin
6 years, 7 months ago (2014-05-19 18:30:54 UTC) #1
Finnur
Sorry for the late reply. Didn't see this yesterday, for some reason. LGTM.
6 years, 7 months ago (2014-05-20 12:53:12 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-20 15:33:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/296503003/1
6 years, 7 months ago (2014-05-20 15:33:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 18:45:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 19:49:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29018)
6 years, 7 months ago (2014-05-20 19:49:44 UTC) #7
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-20 19:57:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/296503003/1
6 years, 7 months ago (2014-05-20 19:58:26 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:13:30 UTC) #10
Message was sent while issue was closed.
Change committed as 271748

Powered by Google App Engine
This is Rietveld 408576698