Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart

Issue 2965023002: Fix inference test expectations for generic function types. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart
diff --git a/pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart b/pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart
index 25163b0a748fd23dcc0876e08fcdcd25ccaae2bd..58a16376a820f7eae2a23abcf9a65d9440367d24 100644
--- a/pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart
+++ b/pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart
@@ -8,7 +8,7 @@ library test;
void main() {
{
String f<S>(int x) => null;
- var /*@type=(int) -> String*/ v = f;
+ var /*@type=<S extends Object>(int) -> String*/ v = f;
v = <T> /*@returnType=String*/ (int x) => null;
v = <T> /*@returnType=String*/ (int x) => "hello";
v = /*error:INVALID_ASSIGNMENT*/ <T> /*@returnType=String*/ (String x) =>
@@ -20,7 +20,7 @@ void main() {
}
{
String f<S>(int x) => null;
- var /*@type=(int) -> String*/ v = f;
+ var /*@type=<S extends Object>(int) -> String*/ v = f;
v = <T> /*@returnType=String*/ (/*@type=int*/ x) => null;
v = <T> /*@returnType=String*/ (/*@type=int*/ x) => "hello";
v = /*info:INFERRED_TYPE_CLOSURE, error:INVALID_ASSIGNMENT*/ <
@@ -35,7 +35,7 @@ void main() {
}
{
List<String> f<S>(int x) => null;
- var /*@type=(int) -> List<String>*/ v = f;
+ var /*@type=<S extends Object>(int) -> List<String>*/ v = f;
v = <T> /*@returnType=List<String>*/ (int x) => null;
v = <T> /*@returnType=List<String>*/ (int x) => /*@typeArgs=String*/ [
"hello"
@@ -55,16 +55,16 @@ void main() {
int int2int<S>(int x) => null;
String int2String<T>(int x) => null;
String string2String<T>(String x) => null;
- var /*@type=(int) -> int*/ x = int2int;
+ var /*@type=<S extends Object>(int) -> int*/ x = int2int;
x = <T> /*@returnType=int*/ (/*@type=int*/ x) => x;
x = <T> /*@returnType=int*/ (/*@type=int*/ x) => x /*@target=num::+*/ + 1;
- var /*@type=(int) -> String*/ y = int2String;
+ var /*@type=<T extends Object>(int) -> String*/ y = int2String;
y = /*info:INFERRED_TYPE_CLOSURE, error:INVALID_ASSIGNMENT*/ <
T> /*@returnType=int*/ (/*@type=int*/ x) =>
x;
y = <T> /*@returnType=String*/ (/*@type=int*/ x) => /*info:DYNAMIC_INVOKE, info:DYNAMIC_CAST*/ x
.substring(3);
- var /*@type=(String) -> String*/ z = string2String;
+ var /*@type=<T extends Object>(String) -> String*/ z = string2String;
z = <T> /*@returnType=String*/ (/*@type=String*/ x) =>
x. /*@target=String::substring*/ substring(3);
}

Powered by Google App Engine
This is Rietveld 408576698