Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2965010: Various dhcpcd fixups. (Closed)

Created:
10 years, 5 months ago by Sam Leffler
Modified:
9 years, 7 months ago
Reviewers:
Nathan Williams
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git//dhcpcd.git
Visibility:
Public.

Description

Various dhcpcd fixups. - fix Rebind; previous use of bind_interface was wrong - don't use signals to effect state changes; call directly into the code to avoid the signal delivery and associated socketpair dance - release lease and terminate if dbus goes away - set nocarrier in dhcpcd.conf to disable carrier checking; we act solely on dbus msgs - while here do some code cleanups (e.g. kill #if 0 code) TEST=do roaming tests and observe a single dhcpcd process renew leases as required; also tested release logic and dbus drop out logic by killing dbus-daemon

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M dhcpcd.h View 1 chunk +2 lines, -0 lines 0 comments Download
M dhcpcd.c View 3 chunks +2 lines, -4 lines 0 comments Download
M dhcpcd.conf View 1 chunk +2 lines, -0 lines 0 comments Download
M dhcpcd-dbus.c View 3 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Leffler
This is everything we discussed except setting the rebind timeout low; I'm not sure about ...
10 years, 5 months ago (2010-07-14 00:42:35 UTC) #1
Nathan Williams
10 years, 5 months ago (2010-07-14 14:27:09 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698