Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 296483012: Revert 271945 "Roll FFmpeg for M37." (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Dale Curtis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271945 "Roll FFmpeg for M37." Broke gclient runhooks on Linux ChromiumOS Builder on Blink waterfall. Bugs 119020 and 236611 will be updated with details. > Roll FFmpeg for M37. > > Syncs to head as of bebce653e5601ceafa004db0eb6b2c7d4d16f0c0. The > roll requires us to stop using some deprecated features: > - Replaces av_get_frame_defaults() with av_frame_unref() per docs. > - Switches FFmpegVideoDecoder to use ref-counted frames. > - Removes error concealment settings and disables error resilience > for all platforms except ChromeOS (since it's required for mpeg4). > > Avoiding these also allows us to disable some deprecated features > wholesale via #defines. > > BUG=119020, 236611 > TEST=all tests (and regression tests) pass under asan > NOTRY=true > R=jrummell@chromium.org, wolenetz@chromium.org > > Review URL: https://codereview.chromium.org/286953005 TBR=dalecurtis@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -75 lines) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/base/audio_video_metadata_extractor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/base/media_file_checker.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/media/cast/test/sender.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M trunk/src/media/cdm/ppapi/external_clear_key/ffmpeg_cdm_audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/cdm/ppapi/external_clear_key/ffmpeg_cdm_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/ffmpeg/ffmpeg_common.h View 2 chunks +1 line, -9 lines 0 comments Download
M trunk/src/media/ffmpeg/ffmpeg_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/filters/audio_file_reader.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/media/filters/ffmpeg_audio_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/media/filters/ffmpeg_demuxer.cc View 1 chunk +9 lines, -1 line 0 comments Download
M trunk/src/media/filters/ffmpeg_h264_to_annex_b_bitstream_converter.cc View 1 chunk +7 lines, -1 line 0 comments Download
M trunk/src/media/filters/ffmpeg_video_decoder.h View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/media/filters/ffmpeg_video_decoder.cc View 7 chunks +38 lines, -37 lines 0 comments Download
M trunk/src/media/filters/pipeline_integration_test_base.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-21 20:16:28 UTC) #1
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-21 20:16:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271956.

Powered by Google App Engine
This is Rietveld 408576698