Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc

Issue 2964823002: Remove confusing keyboard test & focus on input device (Closed)
Patch Set: Break out device check code Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.h" 5 #include "chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.h"
6 6
7 #include <stdint.h>
8
9 #include <algorithm>
10
7 #include "ash/display/window_tree_host_manager.h" 11 #include "ash/display/window_tree_host_manager.h"
8 #include "ash/shell.h" 12 #include "ash/shell.h"
9 #include "content/public/browser/browser_thread.h" 13 #include "content/public/browser/browser_thread.h"
10 #include "ui/display/display.h" 14 #include "ui/display/display.h"
11 #include "ui/display/display_layout.h"
12 #include "ui/display/manager/display_manager.h" 15 #include "ui/display/manager/display_manager.h"
13 #include "ui/display/screen.h" 16 #include "ui/display/screen.h"
17 #include "ui/events/devices/device_data_manager.h"
18 #include "ui/events/devices/touchscreen_device.h"
14 19
15 using content::BrowserThread; 20 using content::BrowserThread;
16 21
17 namespace chromeos { 22 namespace chromeos {
18 23
19 namespace { 24 namespace {
20 25
21 bool TouchSupportAvailable(const display::Display& display) { 26 bool TouchSupportAvailable(const display::Display& display) {
22 return display.touch_support() == 27 return display.touch_support() ==
23 display::Display::TouchSupport::TOUCH_SUPPORT_AVAILABLE; 28 display::Display::TouchSupport::TOUCH_SUPPORT_AVAILABLE;
24 } 29 }
25 30
31 // TODO(felixe): crbug/2964823002
32 const uint16_t ids[] = {0x0457, 0x266e};
33
34 bool UseForOobe(const ui::InputDevice& device) {
35 return std::find(std::begin(ids), std::end(ids), device.vendor_id) !=
36 std::end(ids);
37 }
38
26 } // namespace 39 } // namespace
27 40
28 OobeDisplayChooser::OobeDisplayChooser() : weak_ptr_factory_(this) {} 41 OobeDisplayChooser::OobeDisplayChooser() : weak_ptr_factory_(this) {}
29 42
30 OobeDisplayChooser::~OobeDisplayChooser() {} 43 OobeDisplayChooser::~OobeDisplayChooser() {}
31 44
32 void OobeDisplayChooser::TryToPlaceUiOnTouchDisplay() { 45 void OobeDisplayChooser::TryToPlaceUiOnTouchDisplay() {
33 DCHECK_CURRENTLY_ON(BrowserThread::UI); 46 DCHECK_CURRENTLY_ON(BrowserThread::UI);
34 47
35 // Don't (potentially) queue a second task to run MoveToTouchDisplay if one 48 // Don't (potentially) queue a second task to run MoveToTouchDisplay if one
36 // already is queued. 49 // already is queued.
37 if (weak_ptr_factory_.HasWeakPtrs()) 50 if (weak_ptr_factory_.HasWeakPtrs())
38 return; 51 return;
39 52
40 display::Display primary_display = 53 display::Display primary_display =
41 display::Screen::GetScreen()->GetPrimaryDisplay(); 54 display::Screen::GetScreen()->GetPrimaryDisplay();
42 55
43 if (primary_display.is_valid() && !TouchSupportAvailable(primary_display)) { 56 if (primary_display.is_valid() && !TouchSupportAvailable(primary_display)) {
44 BrowserThread::PostTask( 57 BrowserThread::PostTask(
45 BrowserThread::UI, FROM_HERE, 58 BrowserThread::UI, FROM_HERE,
46 base::BindOnce(&OobeDisplayChooser::MoveToTouchDisplay, 59 base::BindOnce(&OobeDisplayChooser::MoveToTouchDisplay,
47 weak_ptr_factory_.GetWeakPtr())); 60 weak_ptr_factory_.GetWeakPtr()));
48 } 61 }
49 } 62 }
50 63
51 void OobeDisplayChooser::MoveToTouchDisplay() { 64 void OobeDisplayChooser::MoveToTouchDisplay() {
52 DCHECK_CURRENTLY_ON(BrowserThread::UI); 65 DCHECK_CURRENTLY_ON(BrowserThread::UI);
53 66
54 const display::Displays& displays = 67 if (!ui::DeviceDataManager::HasInstance())
55 ash::Shell::Get()->display_manager()->active_only_display_list();
56
57 if (displays.size() <= 1)
58 return; 68 return;
59 69
60 for (const display::Display& display : displays) { 70 const ui::DeviceDataManager* device_manager =
61 if (TouchSupportAvailable(display)) { 71 ui::DeviceDataManager::GetInstance();
62 ash::Shell::Get()->window_tree_host_manager()->SetPrimaryDisplayId( 72 for (const ui::TouchscreenDevice& device :
63 display.id()); 73 device_manager->GetTouchscreenDevices()) {
64 break; 74 if (UseForOobe(device)) {
75 int64_t display_id =
76 device_manager->GetTargetDisplayForTouchDevice(device.id);
77 if (display_id != display::kInvalidDisplayId) {
78 ash::Shell::Get()->window_tree_host_manager()->SetPrimaryDisplayId(
79 display_id);
80 return;
81 }
65 } 82 }
66 } 83 }
67 } 84 }
68 85
69 } // namespace chromeos 86 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698