Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: pkg/compiler/lib/src/js_model/js_strategy.dart

Issue 2964683003: Split implementation of KernelToElementMapImpl (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_model/js_strategy.dart
diff --git a/pkg/compiler/lib/src/js_model/js_strategy.dart b/pkg/compiler/lib/src/js_model/js_strategy.dart
index e2279f667207b8e029c3634e5b8f9665c8ca3302..ad2679edabdc73c53be5d70395a1d5785045a850 100644
--- a/pkg/compiler/lib/src/js_model/js_strategy.dart
+++ b/pkg/compiler/lib/src/js_model/js_strategy.dart
@@ -40,13 +40,14 @@ class JsBackendStrategy implements KernelBackendStrategy {
KernelToElementMapForBuilding _elementMap;
ClosureConversionTask _closureDataLookup;
final GlobalLocalsMap _globalLocalsMap = new GlobalLocalsMap();
+ Sorter _sorter;
JsBackendStrategy(this._compiler);
KernelToElementMapForBuilding get elementMap {
if (_elementMap == null) {
KernelFrontEndStrategy strategy = _compiler.frontendStrategy;
- KernelToElementMapForBuilding elementMap = strategy.elementMap;
+ KernelToElementMapForImpact elementMap = strategy.elementMap;
Siggi Cherem (dart-lang) 2017/06/30 22:19:28 seems like we have a misnomer then?
Johnni Winther 2017/07/03 08:00:57 No. The elementMap of the frontend strategy is a K
_elementMap = new JsKernelToElementMap(
_compiler.reporter,
_compiler.environment,
@@ -133,7 +134,7 @@ class JsBackendStrategy implements KernelBackendStrategy {
@override
Sorter get sorter {
- throw new UnimplementedError('JsBackendStrategy.sorter');
+ return _sorter ??= new KernelSorter(elementMap);
}
@override

Powered by Google App Engine
This is Rietveld 408576698