Split implementation of KernelToElementMapImpl

Split implementation of KernelToElementMapImpl

- to enable testing of pure implementations of the frontend/backend KernelToElementMap interfaces

This introduces Indexed* entities to enable sharing envs/data between K and J elements.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/8ce912063ed749b03f917de89536c8b566a4d196

[Johnni Winther, 2017-06-30 20:22:51]

Description was changed from

==========
Split implementation of KernelToElementMapImpl

- to enable testing of pure implementations of the frontend/backend
KernelToElementMap interfaces
==========

to

==========
Split implementation of KernelToElementMapImpl

- to enable testing of pure implementations of the frontend/backend
KernelToElementMap interfaces

This introduces Indexed* entities to enable sharing envs/data between K and J
elements.
==========

[Johnni Winther, 2017-06-30 20:23:00]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-30 22:19:29]

lgtm

+efortuna - I think this might answer a bit the question on the other CL about
the kernelbackendstrategy vs jsbackendstrategy

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/js_strategy.dart (right):

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/js_strategy.dart:50: KernelToElementMapForImpact
elementMap = strategy.elementMap;
seems like we have a misnomer then?

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:158: MemberEntity
lookupClassMember(KClass cls, String name,
Switch to IndexableClass here and below?

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:470: InterfaceType
_asInstanceOf(InterfaceType type, KClass cls) {
same thing here and below?

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/elements.dart (right):

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/elements.dart:5: /// Entity interfaces for modelling
elements derived from Kernel IR.
ll => l

[Johnni Winther, 2017-07-03 08:00:58]

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/js_strategy.dart (right):

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/js_strategy.dart:50: KernelToElementMapForImpact
elementMap = strategy.elementMap;
On 2017/06/30 22:19:28, Siggi Cherem (dart-lang) wrote:
> seems like we have a misnomer then?

No. The elementMap of the frontend strategy is a KernelToElementMapForImpact
whereas the elementMap of the backend strategy is a
KernelToElementMapForBuilding.

Changed the type of `KernelFrontEndStrategy.elementMap` to
[KernelToElementMapForImpact] instead of [KernelToElementMapForImpactImpl].

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:158: MemberEntity
lookupClassMember(KClass cls, String name,
On 2017/06/30 22:19:28, Siggi Cherem (dart-lang) wrote:
> Switch to IndexableClass here and below?

Yes!

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:470: InterfaceType
_asInstanceOf(InterfaceType type, KClass cls) {
On 2017/06/30 22:19:29, Siggi Cherem (dart-lang) wrote:
> same thing here and below?

Yes!

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/elements.dart (right):

https://codereview.chromium.org/2964683003/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/elements.dart:5: /// Entity interfaces for modelling
elements derived from Kernel IR.
On 2017/06/30 22:19:29, Siggi Cherem (dart-lang) wrote:
> ll => l

Done.

[Johnni Winther, 2017-07-03 08:06:42]

Description was changed from

==========
Split implementation of KernelToElementMapImpl

- to enable testing of pure implementations of the frontend/backend
KernelToElementMap interfaces

This introduces Indexed* entities to enable sharing envs/data between K and J
elements.
==========

to

==========
Split implementation of KernelToElementMapImpl

- to enable testing of pure implementations of the frontend/backend
KernelToElementMap interfaces

This introduces Indexed* entities to enable sharing envs/data between K and J
elements.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8ce912063ed749b03f917de89536c8b566a4d196
==========

[Johnni Winther, 2017-07-03 08:06:43]

Committed patchset #2 (id:20001) manually as
8ce912063ed749b03f917de89536c8b566a4d196 (presubmit successful).