Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2964563002: Removing --disable/enable-threaded-compositing cmdline switches.

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, shans, creis+watch_chromium.org, tfarina, Peter Beverloo, blink-reviews-animation_chromium.org, nasko+codewatch_chromium.org, jam, devtools-reviews_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, pfeldman+blink_chromium.org, darin-cc_chromium.org, darktears, blink-reviews, rjwright, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org, jochen+watch_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing --disable/enable-threaded-compositing cmdline switches. Threaded compositing is the default behavior (chrome's renderers will crash with --disable-threaded-compositing and content_shell will display blank/white web contents). Therefore, this CL removes the related cmdline switches and moves layout tests to always work with threaded compositing. This helps to 1) test what we ship (and not some other, test-only mode) 2) unblocks getting browser-side, OOPIF-friendly pixel-dumps (see https://crbug.com/667551#c5). BUG=738089 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1671 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/ASANExpectations View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 2 chunks +0 lines, -180 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 3 chunks +1 line, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls View 2 chunks +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/SmokeTests View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 9 chunks +3 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 6 chunks +3 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/compositing/visibility/README.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/compositing/visibility/layer-visible-content-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/compositing/visibility/visibility-composited-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/compositing/visibility/visibility-composited-transforms-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/compositing/visibility/visibility-on-distant-descendant-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/compositing/webgl/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/animation-worklet-animator-animate.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/animation-worklet-animator-animate-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/animation-worklet-animator-registration.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/animation-worklet-animator-registration-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/animation-worklet-tests.js View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/basic-plumbing-main-to-worker.js View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/request-animation-frame.js View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/visual-update.js View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/visual-update.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/visual-update-expected.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idle-callback/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idle-callback/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idle-callback/basic.html View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idle-callback/idle_periods.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idle-callback/timeout.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-2d-main.html View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-2d-main-expected.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-2d-worker.html View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-2d-worker-expected.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-main.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-main-expected.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-worker.html View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/OffscreenCanvas-convertToBlob-webgl-worker-expected.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/idleToBlob/README.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/README.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/idle-callback.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/idle-callback-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/printing/README.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/printing/return-from-printing-mode-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/printing/standards-percentage-heights-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/transitions/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/transitions/opacity-transform-transitions-inside-iframe-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/transitions/transition-end-event-multiple-03-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/README.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (5 generated)
Łukasz Anforowicz
Description was changed from ========== Removing --disable/enable-threaded-compositing cmdline switches. Threaded compositing is the default behavior ...
3 years, 5 months ago (2017-06-29 20:03:14 UTC) #1
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-29 20:03:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964563002/1
3 years, 5 months ago (2017-06-29 20:03:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-29 21:10:39 UTC) #4
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 21:10:40 UTC) #5
Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698