cc: Get rid of rasterizer delegate.

cc: Get rid of rasterizer delegate.

It is not needed anymore now that we do not support hybrid rasterization. Gpu-rasterization flag is per page instead of per layer.

BUG=367200
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272335

[alokp, 2014-05-20 23:31:55]

Any suggestion on how to unittest the rasterizer switch?

[reveman, 2014-05-21 04:17:05]

Nice! Removing this makes me happy.

https://codereview.chromium.org/296453009/diff/20001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/296453009/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:118: bool
UseZeroCopyTextureUpload(cc::LayerTreeHostImpl* host_impl) {
Either make these two functions member functions if they take a LTHI as
parameter or pass settings and renderer capabilities to them. Or keep the
temporary variables used before this patch which I think was fine.

https://codereview.chromium.org/296453009/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:1941: DCHECK(tile_manager_);
I don't think it's necessary to check that ::Create succeeds as the only thing
that should allow it to fail is oom.

https://codereview.chromium.org/296453009/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:2058: DCHECK(UseZeroCopyTextureUpload(this));
I don't think this DCHECK makes sense here. You're not doing anything in this
function anymore that rely on this returning true.

[alokp, 2014-05-21 05:24:43]

https://codereview.chromium.org/296453009/diff/20001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/296453009/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:118: bool
UseZeroCopyTextureUpload(cc::LayerTreeHostImpl* host_impl) {
On 2014/05/21 04:17:06, reveman wrote:
> Either make these two functions member functions if they take a LTHI as
> parameter or pass settings and renderer capabilities to them. Or keep the
> temporary variables used before this patch which I think was fine.

Done.

https://codereview.chromium.org/296453009/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:1941: DCHECK(tile_manager_);
On 2014/05/21 04:17:06, reveman wrote:
> I don't think it's necessary to check that ::Create succeeds as the only thing
> that should allow it to fail is oom.

Done.

https://codereview.chromium.org/296453009/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:2058: DCHECK(UseZeroCopyTextureUpload(this));
On 2014/05/21 04:17:06, reveman wrote:
> I don't think this DCHECK makes sense here. You're not doing anything in this
> function anymore that rely on this returning true.

Done.

[alokp, 2014-05-22 16:18:32]

Dave: Did you have any more comments?

[reveman, 2014-05-22 17:04:29]

lgtm

[alokp, 2014-05-22 17:51:50]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2014-05-22 17:53:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alokp@chromium.org/296453009/80001

[commit-bot: I haz the power, 2014-05-22 20:51:23]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[commit-bot: I haz the power, 2014-05-22 21:49:54]

Change committed as 272335