Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 296453005: Componentize chrome/browser/network_time (Closed)

Created:
6 years, 7 months ago by hashimoto
Modified:
6 years, 6 months ago
Reviewers:
haitaol1, sky, blundell
CC:
chromium-reviews, tim+watch_chromium.org, jar (doing other things), haitaol+watch_chromium.org, asvitkine+watch_chromium.org, Ilya Sherman, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Componentize chrome/browser/network_time Move chrome/browser/network_time to components/network_time network_time.h is removed as it's unused. BUG=371470 TEST=git cl try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274887

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : rebase & iOS fix #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : Fix iOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -421 lines) Patch
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_process.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/network_time/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/network_time/network_time.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/network_time/network_time_tracker.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/network_time/network_time_tracker.cc View 1 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/network_time/network_time_tracker_unittest.cc View 1 1 chunk +0 lines, -159 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M components/OWNERS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/components.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
A + components/network_time.gypi View 1 2 chunks +5 lines, -3 lines 0 comments Download
A + components/network_time/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/network_time/network_time_pref_names.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
A components/network_time/network_time_pref_names.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
A + components/network_time/network_time_tracker.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
A + components/network_time/network_time_tracker.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
A + components/network_time/network_time_tracker_unittest.cc View 1 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 24 (0 generated)
hashimoto
Please review. haitaol@: as an owner of network_time. blundell@: as an owner of components.
6 years, 6 months ago (2014-05-30 14:21:38 UTC) #1
blundell
w00t! Awesome! LGTM https://codereview.chromium.org/296453005/diff/200001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/296453005/diff/200001/components/components_tests.gyp#newcode376 components/components_tests.gyp:376: ['include', '^language_usage_metrics/'], Please add network_time here.
6 years, 6 months ago (2014-06-02 07:22:56 UTC) #2
hashimoto
https://codereview.chromium.org/296453005/diff/200001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/296453005/diff/200001/components/components_tests.gyp#newcode376 components/components_tests.gyp:376: ['include', '^language_usage_metrics/'], On 2014/06/02 07:22:56, blundell wrote: > Please ...
6 years, 6 months ago (2014-06-02 08:32:47 UTC) #3
haitaol1
LGTM. Thanks for working on this.
6 years, 6 months ago (2014-06-02 20:29:04 UTC) #4
hashimoto
sky, could you review changes to the code under chrome/browser/ (other than c/b/network_time and c/b/sync) ...
6 years, 6 months ago (2014-06-03 01:00:21 UTC) #5
sky
LGTM
6 years, 6 months ago (2014-06-03 15:48:37 UTC) #6
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-04 04:23:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/296453005/210001
6 years, 6 months ago (2014-06-04 04:24:36 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 04:35:17 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 04:38:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71497)
6 years, 6 months ago (2014-06-04 04:38:49 UTC) #11
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-04 04:43:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/296453005/210001
6 years, 6 months ago (2014-06-04 04:44:51 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 04:57:22 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 05:01:07 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71502)
6 years, 6 months ago (2014-06-04 05:01:08 UTC) #16
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-04 05:35:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/296453005/230001
6 years, 6 months ago (2014-06-04 05:36:20 UTC) #18
blundell
https://codereview.chromium.org/296453005/diff/230001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/296453005/diff/230001/components/components_tests.gyp#newcode339 components/components_tests.gyp:339: 'components.gyp:network_time', Oops, this needs to be in the list ...
6 years, 6 months ago (2014-06-04 12:37:07 UTC) #19
hashimoto
https://codereview.chromium.org/296453005/diff/230001/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/296453005/diff/230001/components/components_tests.gyp#newcode339 components/components_tests.gyp:339: 'components.gyp:network_time', On 2014/06/04 12:37:06, blundell wrote: > Oops, this ...
6 years, 6 months ago (2014-06-04 12:41:54 UTC) #20
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-04 12:42:04 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/296453005/250001
6 years, 6 months ago (2014-06-04 12:43:02 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 16:55:46 UTC) #23
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 19:41:36 UTC) #24
Message was sent while issue was closed. 
Change committed as 274887

Powered by Google App Engine
This is Rietveld 408576698