Issue 2964493002: Move implementation from KernelToElementMapImpl to *BaseImpl and *ForImpactImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2964493002: Move implementation from KernelToElementMapImpl to BaseImpl and ForImpactImpl (Closed)

Created:
3 years, 5 months ago by Johnni Winther

Modified:
3 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Move implementation from KernelToElementMapImpl to *BaseImpl and *ForImpactImpl This is a step towards splitting element maps for impact and building while still reusing common parts. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/469335dfb696def9cd5c236ecb538bf81845c857

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+333 lines, -307 lines)			Patch
	M	pkg/compiler/lib/src/js_model/js_strategy.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View		25 chunks	+327 lines, -306 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 5 months ago (2017-06-30 07:29:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
469335dfb696def9cd5c236ecb538bf81845c857 (presubmit successful).