Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 2964453002: Use style::CONTEXT_TEXTFIELD for Combobox and Textfield (Closed)
Patch Set: Try mac again Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index 7e9dbae11d8d961b29cab6b5deea857572a2bc70..162569bb7033a5deff8105ea8f4c79e2071fd16e 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -385,9 +385,9 @@ SkColor Textfield::GetTextColor() const {
if (!use_default_text_color_)
return text_color_;
- return GetNativeTheme()->GetSystemColor(read_only() || !enabled() ?
- ui::NativeTheme::kColorId_TextfieldReadOnlyColor :
- ui::NativeTheme::kColorId_TextfieldDefaultColor);
+ int style =
+ read_only() || !enabled() ? style::STYLE_DISABLED : style::STYLE_PRIMARY;
Peter Kasting 2017/06/29 20:24:57 Nit: Please put parens around the condition before
tapted 2017/06/30 05:53:43 Done.
+ return style::GetColor(style::CONTEXT_TEXTFIELD, style, GetNativeTheme());
}
void Textfield::SetTextColor(SkColor color) {

Powered by Google App Engine
This is Rietveld 408576698