Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 296443003: Deleted unused PNG files (Closed)

Created:
6 years, 7 months ago by François Beaufort
Modified:
6 years, 7 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, chromoting-reviews_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, vsevik, jam, darin-cc_chromium.org, yfriedman+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, paulirish+reviews_chromium.org, bulach+watch_chromium.org, oshima+watch_chromium.org, ilevy-cc_chromium.org, piman+watch_chromium.org, tfarina, yurys, estade+watch_chromium.org, klundberg+watch_chromium.org, dharcourt, pfeldman, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

In order to remove unused png files inside the chromium source code, I've first wrote a simple python script to narrow my research. With http://pastebin.com/ZEz4TgzD, I'm doing three things: - Restricting my search to folders I'm familiar with. - Listing all strings that end with ".png" - Grabbing only PNG files that haven't been created in 2014 Then, because I know there might some cases that are not covered, I've looked into *all of them* to make sure they were not used for real anymore. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272080

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
D chrome/app/theme/chromium/product_logo_name.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/back.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/back_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/back_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/back_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/forward.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/forward_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/forward_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/forward_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/home_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/home_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/reload_dimmed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/reload_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/reload_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/stop_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/stop_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/stop_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/tools_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/tools_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/back.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/back_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/back_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/back_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/forward.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/forward_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/forward_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/forward_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/home_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/home_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/reload_dimmed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/reload_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/reload_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/stop_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/stop_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/tools_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/tools_pressed.png View Binary file 0 comments Download
D chrome/browser/policy/resources/access_control.png View Binary file 0 comments Download
D chrome/browser/resources/2x/ssl_roadblock_icon.png View Binary file 0 comments Download
D chrome/browser/resources/2x/twisty_closed.png View Binary file 0 comments Download
D chrome/browser/resources/2x/twisty_closed_rtl.png View Binary file 0 comments Download
D chrome/browser/resources/2x/twisty_open.png View Binary file 0 comments Download
D chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_recent.png View Binary file 0 comments Download
D chrome/browser/resources/bookmark_manager/images/bookmark_manager_recent.png View Binary file 0 comments Download
D chrome/browser/resources/chromeos/images/broken_robot.png View Binary file 0 comments Download
D chrome/browser/resources/extensions/extension_error_inspect.png View Binary file 0 comments Download
D chrome/browser/resources/ntp4/images/2x/app_promo_button.png View Binary file 0 comments Download
D chrome/browser/resources/options/arrow_next.png View Binary file 0 comments Download
D chrome/browser/resources/ssl/twisty_closed.png View Binary file 0 comments Download
D chrome/browser/resources/ssl/twisty_closed_rtl.png View Binary file 0 comments Download
D chrome/browser/resources/ssl/twisty_open.png View Binary file 0 comments Download
D chrome/browser/resources/twisty_closed.png View Binary file 0 comments Download
D chrome/browser/resources/twisty_closed_rtl.png View Binary file 0 comments Download
D chrome/browser/resources/twisty_open.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/api/fontSettings/images/slider/slide_bar_fill_right.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/api/fontSettings/images/slider/slide_bar_left.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/api/infobars/sandwichbar/sandwich-19.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/extensions/gdocs/img/icons/trashed.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/extensions/imageinfo/imageinfo-19.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/extensions/oauth_contacts/img/icon-32.png View Binary file 0 comments Download
D chrome/common/extensions/docs/static/images/mocks/colt.png View Binary file 0 comments Download
D chrome/common/extensions/docs/static/images/mocks/devsummit.png View Binary file 0 comments Download
D chrome/common/extensions/docs/static/images/mocks/dude.png View Binary file 0 comments Download
D chrome/common/extensions/docs/static/images/mocks/mobilescreen.png View Binary file 0 comments Download
D chrome/common/extensions/docs/static/images/sidearrow.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/notifications/galore/app/images/close-highlighted-14x14.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/notifications/galore/app/images/menu-highlighted-14x14.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/notifications/galore/app/images/wrench-14x14.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/notifications/galore/app/images/wrench-highlighted-14x14.png View Binary file 0 comments Download
D chrome/test/data/extensions/subscribe_page_action/feed-icon-16x16-subscribed.png View Binary file 0 comments Download
D chrome/test/data/printing/iframe.png View Binary file 0 comments Download
D chrome/test/data/printing/popup_delayed_print.png View Binary file 0 comments Download
D chrome/test/data/printing/test1_cleartype.png View Binary file 0 comments Download
D chrome/test/data/printing/test3.png View Binary file 0 comments Download
D chrome/test/data/printing/test4.png View Binary file 0 comments Download
D ui/webui/resources/images/1.5x/laptop.png View Binary file 0 comments Download
D ui/webui/resources/images/1.5x/phone.png View Binary file 0 comments Download
D ui/webui/resources/images/1.5x/tablet.png View Binary file 0 comments Download
D ui/webui/resources/images/2x/laptop.png View Binary file 0 comments Download
D ui/webui/resources/images/2x/phone.png View Binary file 0 comments Download
D ui/webui/resources/images/2x/tablet.png View Binary file 0 comments Download
D ui/webui/resources/images/laptop.png View Binary file 0 comments Download
D ui/webui/resources/images/phone.png View Binary file 0 comments Download
D ui/webui/resources/images/tablet.png View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
François Beaufort
Hello Scott, Do you mind having a look at this (let's clean) CL? Thank you, ...
6 years, 7 months ago (2014-05-21 13:46:55 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-21 16:09:46 UTC) #2
François Beaufort
The CQ bit was checked by beaufort.francois@gmail.com
6 years, 7 months ago (2014-05-21 16:14:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/296443003/100001
6 years, 7 months ago (2014-05-21 19:59:04 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 03:57:30 UTC) #5
Message was sent while issue was closed.
Change committed as 272080

Powered by Google App Engine
This is Rietveld 408576698