Clean up coding style

Clean up coding style

BUG=

R=rtenneti@chromium.org,wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271805

[Jihun Brent Kim, 2014-05-17 17:02:19]

The CQ bit was checked by devgrapher@gmail.com

[Jihun Brent Kim, 2014-05-17 17:02:22]

The CQ bit was unchecked by devgrapher@gmail.com

[Jihun Brent Kim, 2014-05-17 17:24:53]

Please review this.

[ramant (doing other things), 2014-05-19 17:42:49]

lgtm

[wtc, 2014-05-19 19:08:52]

Patch set 1 LGTM.

https://codereview.chromium.org/296433002/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/296433002/diff/1/AUTHORS#newcode162
AUTHORS:162: Jihun Brent Kim <devgrapher@gmail.com>

I verified that Jihun signed the CLA for Chromium.

https://codereview.chromium.org/296433002/diff/1/net/url_request/url_fetcher_...
File net/url_request/url_fetcher_impl.h (right):

https://codereview.chromium.org/296433002/diff/1/net/url_request/url_fetcher_...
net/url_request/url_fetcher_impl.h:17: #include <string>

Is this suggested by some tool? I'm just wondering how we can maintain this,
because the code can still be compiled without including <string>.

https://codereview.chromium.org/296433002/diff/1/net/url_request/url_request_...
File net/url_request/url_request_job.cc (right):

https://codereview.chromium.org/296433002/diff/1/net/url_request/url_request_...
net/url_request/url_request_job.cc:402: //
DCHECK(!request_->status().is_io_pending());

Nit: this isn't really a comment. Here we are commenting out a line of code, so
it seems fine to not have that space. Another way to deal with this is to use
#if 0:

#if 0
  DCHECK(!request_->status().is_io_pending());
#endif

https://codereview.chromium.org/296433002/diff/1/net/url_request/url_request_...
File net/url_request/url_request_job_factory_impl.h (right):

https://codereview.chromium.org/296433002/diff/1/net/url_request/url_request_...
net/url_request/url_request_job_factory_impl.h:10: #include <vector>

Nit: <vector> can be deleted. std::vector is not used in this header.

[Jihun Brent Kim, 2014-05-19 23:18:53]

The CQ bit was checked by devgrapher@gmail.com

[Jihun Brent Kim, 2014-05-19 23:18:56]

The CQ bit was unchecked by devgrapher@gmail.com

[Jihun Brent Kim, 2014-05-20 01:31:01]

On 2014/05/19 19:08:52, wtc wrote:
> Patch set 1 LGTM.
> 
> https://codereview.chromium.org/296433002/diff/1/AUTHORS
> File AUTHORS (right):
> 
> https://codereview.chromium.org/296433002/diff/1/AUTHORS#newcode162
> AUTHORS:162: Jihun Brent Kim <mailto:devgrapher@gmail.com>
> 
> I verified that Jihun signed the CLA for Chromium.
> 
>
https://codereview.chromium.org/296433002/diff/1/net/url_request/url_fetcher_...
> File net/url_request/url_fetcher_impl.h (right):
> 
>
https://codereview.chromium.org/296433002/diff/1/net/url_request/url_fetcher_...
> net/url_request/url_fetcher_impl.h:17: #include <string>
> 
> Is this suggested by some tool? I'm just wondering how we can maintain this,
> because the code can still be compiled without including <string>.
> 
>
https://codereview.chromium.org/296433002/diff/1/net/url_request/url_request_...
> File net/url_request/url_request_job.cc (right):
> 
>
https://codereview.chromium.org/296433002/diff/1/net/url_request/url_request_...
> net/url_request/url_request_job.cc:402: //
> DCHECK(!request_->status().is_io_pending());
> 
> Nit: this isn't really a comment. Here we are commenting out a line of code,
so
> it seems fine to not have that space. Another way to deal with this is to use
> #if 0:
> 
> #if 0
>   DCHECK(!request_->status().is_io_pending());
> #endif
> 
>
https://codereview.chromium.org/296433002/diff/1/net/url_request/url_request_...
> File net/url_request/url_request_job_factory_impl.h (right):
> 
>
https://codereview.chromium.org/296433002/diff/1/net/url_request/url_request_...
> net/url_request/url_request_job_factory_impl.h:10: #include <vector>
> 
> Nit: <vector> can be deleted. std::vector is not used in this header.

Thank you for your review.

As you commented, I uploaded additional patch set.
Please check up this again.

[wtc, 2014-05-20 16:39:04]

Patch set 2 LGTM.

Nit: you can add a R= line to the CL's description to list the code reviewers.
For example,

R=rtenneti@chromium.org,wtc@chromium.org

[Jihun Brent Kim, 2014-05-20 18:13:33]

The CQ bit was checked by devgrapher@gmail.com

[commit-bot: I haz the power, 2014-05-20 18:13:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/devgrapher@gmail.com/296433002/10001

[commit-bot: I haz the power, 2014-05-21 01:58:31]

Change committed as 271805