Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2964293002: CrOS Settings: Add skeleton page for multidevice section. (Closed)
Patch Set: Update browsertest Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/basic_page/basic_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
index fe8cc8629fefeca5e288ccda49a0e075c5abfaa2..3aaa1bff53d5711860126b32ab095b65252ad7cc 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -18,9 +18,13 @@ Polymer({
notify: true,
},
+ // <if expr="chromeos">
showAndroidApps: Boolean,
+ showMultidevice: Boolean,
+
havePlayStoreApp: Boolean,
+ // </if>
/** @type {!AndroidAppsInfo|undefined} */
androidAppsInfo: Object,
@@ -183,6 +187,16 @@ Polymer({
return !this.hasExpandedSection_ &&
loadTimeData.getBoolean('isSecondaryUser');
},
+
+ /**
+ * @param {boolean|undefined} visibility
+ * @return {boolean} Whether to show the multidevice settings page.
+ * @private
+ */
+ showMultidevicePage_: function(visibility) {
dpapad 2017/07/06 18:59:02 Still here.
Oren Blasberg 2017/07/06 19:20:30 Done.
+ return loadTimeData.getBoolean('enableMultideviceSettings') &&
+ this.showPage_(visibility);
+ },
// </if>
/** @private */
@@ -219,6 +233,16 @@ Polymer({
return true;
},
+ /**
+ * @return {boolean} Whether to show the multidevice settings page.
+ * @private
+ */
+ shouldShowMultidevice_: function() {
+ var visibility = /** @type {boolean|undefined} */ (
+ this.get('pageVisibility.multidevice'));
+ return this.showMultidevice && this.showPage_(visibility);
+ },
+
/**
* Hides everything but the newly expanded subpage.
* @private

Powered by Google App Engine
This is Rietveld 408576698