CrOS Settings: Add skeleton page for multidevice section.

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/i18n/number_formatting.h"
@@ skipping 2010 matching lines @@
       {"advancedFontSettings", IDS_SETTINGS_ADVANCED_FONT_SETTINGS},
       {"openAdvancedFontSettings", IDS_SETTINGS_OPEN_ADVANCED_FONT_SETTINGS},
       {"requiresWebStoreExtension", IDS_SETTINGS_REQUIRES_WEB_STORE_EXTENSION},
       {"quickBrownFox", IDS_SETTINGS_QUICK_BROWN_FOX},
   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));
 }
 
 #if defined(OS_CHROMEOS)
+void AddMultideviceStrings(content::WebUIDataSource* html_source) {
+  LocalizedString localized_strings[] = {

[Lei Zhang, 2017/07/13 20:56:58]

Can this be const? (And all the others in this file)

[Oren Blasberg, 2017/07/13 23:07:05]

Adding const does not work..

../../chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:2037:3:
error: no matching function for call to 'AddLocalizedStringsBulk'
  AddLocalizedStringsBulk(html_source, localized_strings,
  ^~~~~~~~~~~~~~~~~~~~~~~
../../chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:70:6:
note: candidate function not viable: no known conversion from 'const
settings::(anonymous namespace)::LocalizedString [3]' to 'settings::(anonymous
namespace)::LocalizedString *' for 2nd argument
void AddLocalizedStringsBulk(content::WebUIDataSource* html_source,
     ^



Deferring this -- as dpapad@ suggested, the change can be made orthogonally to
this CL.

+      {"multidevicePageTitle", IDS_SETTINGS_MULTIDEVICE},
+      {"smsConnect", IDS_SETTINGS_MULTIDEVICE_SMS_CONNECT},
+      {"smsConnectSummary", IDS_SETTINGS_MULTIDEVICE_SMS_CONNECT_SUMMARY},
+  };
+  AddLocalizedStringsBulk(html_source, localized_strings,
+                          arraysize(localized_strings));
+
+  html_source->AddBoolean("enableMultideviceSettings",
+                          base::FeatureList::IsEnabled(features::kMultidevice));
+}
+#endif
+
+#if defined(OS_CHROMEOS)
 void AddOncStrings(content::WebUIDataSource* html_source) {
   LocalizedString onc_property_strings[] = {
       // Thes strings are generated by prepending 'Onc' to the ONC property
       // name. Any '.' in the property name is replaced with '-'. Properties
       // with translatable enumerated values have the value appended after '_'.
       {"OncCellular-APN-AccessPointName",
        IDS_ONC_CELLULAR_APN_ACCESS_POINT_NAME},
       {"OncCellular-APN-AccessPointName_none",
        IDS_ONC_CELLULAR_APN_ACCESS_POINT_NAME_NONE},
       {"OncCellular-APN-Password", IDS_ONC_CELLULAR_APN_PASSWORD},
@@ skipping 119 matching lines @@
 
 #if defined(OS_CHROMEOS)
   AddAccountUITweaksStrings(html_source, profile);
   AddAndroidAppStrings(html_source);
   AddBluetoothStrings(html_source);
   AddChromeOSUserStrings(html_source, profile);
   AddDateTimeStrings(html_source);
   AddDeviceStrings(html_source);
   AddEasyUnlockStrings(html_source);
   AddInternetStrings(html_source);
+  AddMultideviceStrings(html_source);
   AddOncStrings(html_source);
   AddUsersStrings(html_source);
 #else
   AddDefaultBrowserStrings(html_source);
   AddImportDataStrings(html_source);
   AddSystemStrings(html_source);
 #endif
 
 #if defined(USE_NSS_CERTS)
   AddCertificateManagerStrings(html_source);
 #endif
 
 #if defined(OS_CHROMEOS)
   chromeos::network_element::AddLocalizedStrings(html_source);
 #endif
   policy_indicator::AddLocalizedStrings(html_source);
 
   html_source->SetJsonPath(kLocalizedStringsFile);
 }
 
 }  // namespace settings