chrome/browser/resources/settings/multidevice_page/multidevice_page.html - Issue 2964293002: CrOS Settings: Add skeleton page for multidevice section.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/multidevice_page/multidevice_page.html

Issue 2964293002: CrOS Settings: Add skeleton page for multidevice section. (Closed)

Patch Set: Address second round of comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/multidevice_page/compiled_resources2.gyp ('K') | « chrome/browser/resources/settings/multidevice_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/multidevice_page/multidevice_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">

	4 <link rel="import" href="../prefs/prefs.html">

	5 <link rel="import" href="../settings_shared_css.html">

	6

	7 <dom-module id="settings-multidevice-page">

	8 <template>

	9 <style include="settings-shared"></style>

	10 <div id="multidevice" class="settings-box two-line">
	dpapad 2017/07/06 20:44:47 All the IDs below this point are not used by any C All the IDs below this point are not used by any CSS rule, JS querySelector, or any of the dummy tests. Let's remove them. The only thing that is needed is the CSS classes for styling (setting-box, two-line, start). Oren Blasberg 2017/07/06 21:22:11 smsConnectToggleLabel is used by paper-toggle-butt Show quoted text On 2017/07/06 20:44:47, dpapad wrote: > All the IDs below this point are not used by any CSS rule, JS querySelector, or > any of the dummy tests. Let's remove them. The only thing that is needed is the > CSS classes for styling (setting-box, two-line, start). smsConnectToggleLabel is used by paper-toggle-button below, in the aria-labelledby attribute ^ So I am keeping that one intact. Removed the others.
	11 <div id="smsConnectToggleLabel" class="start">

	12 $i18n{smsConnect}

	13 </div>

	14 <paper-toggle-button id="enableSmsConnect"

	15 checked="{{smsConnectToggleState_}}"

	16 aria-labelledby="smsConnectToggleLabel">

	17 </paper-toggle-button>

	18 </div>

	19 </template>

	20 <script src="multidevice_page.js"></script>

	21 </dom-module>

OLD	NEW