chrome/browser/resources/settings/multidevice_page/compiled_resources2.gyp - Issue 2964293002: CrOS Settings: Add skeleton page for multidevice section.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/multidevice_page/compiled_resources2.gyp

Issue 2964293002: CrOS Settings: Add skeleton page for multidevice section. (Closed)

Patch Set: Address second round of comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'targets': [

	6 {

	7 'target_name': 'multidevice_page',

	8 'dependencies': [

	9 '../compiled_resources2.gyp:route',
	dpapad 2017/07/06 20:44:47 None of the dependencies in this list are actually None of the dependencies in this list are actually needed to successfully compile this file. Can you remove? Oren Blasberg 2017/07/06 21:22:11 Done. Show quoted text On 2017/07/06 20:44:47, dpapad wrote: > None of the dependencies in this list are actually needed to successfully > compile this file. Can you remove? Done.
	10 '../settings_page/compiled_resources2.gyp:settings_animated_pages',

	11 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',

	12 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:icon',

	13 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:i18n_behavior',

	14 ],

	15 'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi '],

	16 },

	17 ],

	18 }

OLD	NEW