chrome/browser/resources/settings/multidevice_page/multidevice_page.html - Issue 2964293002: CrOS Settings: Add skeleton page for multidevice section.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/multidevice_page/multidevice_page.html

Issue 2964293002: CrOS Settings: Add skeleton page for multidevice section. (Closed)

Patch Set: Update browsertest Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/basic_page/basic_page.js ('K') | « chrome/browser/resources/settings/multidevice_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/multidevice_page/multidevice_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2

	3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">

	5 <link rel="import" href="../i18n_setup.html">
	dpapad 2017/07/06 18:59:02 I don't think this is necessary. multidevice_page. I don't think this is necessary. multidevice_page.js itself is not accessing loadTimeData, so it does not directly depend on it. Oren Blasberg 2017/07/06 19:20:30 Done. Show quoted text On 2017/07/06 18:59:02, dpapad wrote: > I don't think this is necessary. multidevice_page.js itself is not accessing > loadTimeData, so it does not directly depend on it. Done.
	6 <link rel="import" href="../icons.html">

	7 <link rel="import" href="../prefs/prefs.html">

	8 <link rel="import" href="../settings_page/settings_animated_pages.html">

	9 <link rel="import" href="../settings_shared_css.html">

	10

	11 <dom-module id="settings-multidevice-page">

	12 <template>

	13 <style include="settings-shared">

	14 </style>

	15 <settings-animated-pages id="pages" section="multidevice">
	dpapad 2017/07/06 18:59:02 Currently this page does not have any subpages (se Currently this page does not have any subpages (settings-subpage). So settings-animated-pages and neon-animatable usage is unnecessary for now. For a minimal settings page that has no subpages you can see an example at https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/date_t.... Oren Blasberg 2017/07/06 19:20:30 Done. I appreciate that example link. Also got ri Show quoted text On 2017/07/06 18:59:02, dpapad wrote: > Currently this page does not have any subpages (settings-subpage). So > settings-animated-pages and neon-animatable usage is unnecessary for now. For a > minimal settings page that has no subpages you can see an example at > https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/date_t.... Done. I appreciate that example link. Also got rid of the icon and separator to simplify further.
	16 <neon-animatable route-path="default">

	17 <div id="multidevice" class="settings-box two-line">

	18 <iron-icon icon="settings:sync"></iron-icon>

	19 <div id="smsConnectToggleLabel" class="middle">

	20 $i18n{smsConnect}

	21 </div>

	22 <div class="separator"></div>

	23 <paper-toggle-button id="enableSmsConnect"

	24 checked="{{smsConnectToggleState_}}"

	25 aria-labelledby="smsConnectToggleLabel">

	26 </paper-toggle-button>

	27 </div>

	28 </neon-animatable>

	29 </settings-animated-pages>

	30 </template>

	31 <script src="multidevice_page.js"></script>

	32 </dom-module>

OLD	NEW