Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: components/certificate_reporting/error_report_unittest.cc

Issue 2964283002: Add chrome channel to cert logger reports (Closed)
Patch Set: Fix build errors Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/certificate_reporting/error_report.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/certificate_reporting/error_report_unittest.cc
diff --git a/components/certificate_reporting/error_report_unittest.cc b/components/certificate_reporting/error_report_unittest.cc
index 03667c5b973ed262cbb8d99cb6095a1b4518336a..58186257888d45abe890911eafbb31d84f98eac5 100644
--- a/components/certificate_reporting/error_report_unittest.cc
+++ b/components/certificate_reporting/error_report_unittest.cc
@@ -18,6 +18,7 @@
#include "components/certificate_reporting/cert_logger.pb.h"
#include "components/network_time/network_time_test_utils.h"
#include "components/prefs/testing_pref_service.h"
+#include "components/version_info/version_info.h"
#include "net/cert/cert_status_flags.h"
#include "net/ssl/ssl_info.h"
#include "net/test/cert_test_util.h"
@@ -247,6 +248,37 @@ TEST(ErrorReportTest, NetworkTimeQueryingFeatureInfo) {
.network_time_query_behavior());
}
+TEST(ErrorReportTest, TestChromeChannelIncluded) {
+ struct ChannelTestCase {
+ version_info::Channel channel;
+ CertLoggerRequest::ChromeChannel expected_channel;
+ } kTestCases[] = {
+ {version_info::Channel::UNKNOWN,
+ CertLoggerRequest::CHROME_CHANNEL_UNKNOWN},
+ {version_info::Channel::DEV, CertLoggerRequest::CHROME_CHANNEL_DEV},
+ {version_info::Channel::CANARY, CertLoggerRequest::CHROME_CHANNEL_CANARY},
+ {version_info::Channel::BETA, CertLoggerRequest::CHROME_CHANNEL_BETA},
+ {version_info::Channel::STABLE,
+ CertLoggerRequest::CHROME_CHANNEL_STABLE}};
+
+ // Create a report, set its channel value and check if we
+ // get back test_case.expected_channel.
+ for (const ChannelTestCase& test_case : kTestCases) {
+ SSLInfo ssl_info;
+ ASSERT_NO_FATAL_FAILURE(
+ GetTestSSLInfo(INCLUDE_UNVERIFIED_CERT_CHAIN, &ssl_info, kCertStatus));
+ ErrorReport report(kDummyHostname, ssl_info);
+
+ report.AddChromeChannel(test_case.channel);
+ std::string serialized_report;
+ ASSERT_TRUE(report.Serialize(&serialized_report));
+
+ CertLoggerRequest parsed;
+ ASSERT_TRUE(parsed.ParseFromString(serialized_report));
+ EXPECT_EQ(test_case.expected_channel, parsed.chrome_channel());
+ }
+}
+
#if defined(OS_ANDROID)
// Tests that information about the Android AIA fetching feature is included in
// the report.
« no previous file with comments | « components/certificate_reporting/error_report.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698