Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2425)

Unified Diff: chrome/browser/ssl/certificate_reporting_test_utils.h

Issue 2964283002: Add chrome channel to cert logger reports (Closed)
Patch Set: Fix build errors Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/cert_report_helper.cc ('k') | chrome/browser/ssl/certificate_reporting_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/certificate_reporting_test_utils.h
diff --git a/chrome/browser/ssl/certificate_reporting_test_utils.h b/chrome/browser/ssl/certificate_reporting_test_utils.h
index 94d7bdb40f0ed0a861b89233397a5fccd649bef7..6628bdfb46ed9eb949b08e437c51c083528847a2 100644
--- a/chrome/browser/ssl/certificate_reporting_test_utils.h
+++ b/chrome/browser/ssl/certificate_reporting_test_utils.h
@@ -10,6 +10,7 @@
#include "base/macros.h"
#include "chrome/browser/ssl/ssl_cert_reporter.h"
+#include "components/certificate_reporting/cert_logger.pb.h"
#include "components/certificate_reporting/error_reporter.h"
class Browser;
@@ -36,13 +37,18 @@ class SSLCertReporterCallback {
explicit SSLCertReporterCallback(base::RunLoop* run_loop);
~SSLCertReporterCallback();
- void ReportSent(const std::string& hostname);
+ void ReportSent(const std::string& hostname,
+ const certificate_reporting::CertLoggerRequest::ChromeChannel
+ chrome_channel);
const std::string& GetLatestHostnameReported() const;
+ certificate_reporting::CertLoggerRequest::ChromeChannel
+ GetLatestChromeChannelReported() const;
private:
base::RunLoop* run_loop_;
std::string latest_hostname_reported_;
+ certificate_reporting::CertLoggerRequest::ChromeChannel chrome_channel_;
DISALLOW_COPY_AND_ASSIGN(SSLCertReporterCallback);
};
@@ -55,7 +61,10 @@ void SetCertReportingOptIn(Browser* browser, OptIn opt_in);
// |report_sent_callback| when a report is sent. It also checks that a
// report is sent or not sent according to |expect_report|.
std::unique_ptr<SSLCertReporter> CreateMockSSLCertReporter(
- const base::Callback<void(const std::string&)>& report_sent_callback,
+ const base::Callback<
+ void(const std::string&,
+ const certificate_reporting::CertLoggerRequest_ChromeChannel)>&
+ report_sent_callback,
ExpectReport expect_report);
// Returns whether a report should be expected (due to the Finch config)
« no previous file with comments | « chrome/browser/ssl/cert_report_helper.cc ('k') | chrome/browser/ssl/certificate_reporting_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698