ios/chrome/browser/ui/BUILD.gn - Issue 2964233002: [ios] BubbleViewController and BubbleView stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/BUILD.gn

Issue 2964233002: [ios] BubbleViewController and BubbleView stubs. (Closed)

Patch Set: Add BubbleView, remove BubbleConfiguration Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/BUILD.gn

diff --git a/ios/chrome/browser/ui/BUILD.gn b/ios/chrome/browser/ui/BUILD.gn

index 9c1a36a209c4a73fdd52d33d23b2aa377ef85ea9..4f258c0b0b108b4243b42ed31b547889f8a5805f 100644

--- a/ios/chrome/browser/ui/BUILD.gn

+++ b/ios/chrome/browser/ui/BUILD.gn

@@ -272,6 +272,7 @@ source_set("ui_internal_arc") {

"//ios/chrome/browser/ui/alert_coordinator",

"//ios/chrome/browser/ui/authentication",

"//ios/chrome/browser/ui/bookmarks",

+ "//ios/chrome/browser/ui/bubble_promo",

edchin 2017/07/06 04:56:19 I'm curious as to the naming convention here. Why

helenlyang 2017/07/06 22:21:57 I felt that "bubble_promo" was more specific than

edchin 2017/07/07 04:24:10 I think we should just go with bubble.

"//ios/chrome/browser/ui/colors",

"//ios/chrome/browser/ui/commands",

"//ios/chrome/browser/ui/context_menu",

@@ -393,6 +394,7 @@ source_set("ui_internal") {