Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: ios/chrome/browser/ui/bubble_promo/bubble_view_controller.mm

Issue 2964233002: [ios] BubbleViewController and BubbleView stubs. (Closed)
Patch Set: Add BubbleView property to BubbleVC Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "ios/chrome/browser/ui/bubble_promo/bubble_view_controller.h"
6 #import "ios/chrome/browser/ui/bubble_promo/bubble_view.h"
7
8 #if !defined(__has_feature) || !__has_feature(objc_arc)
9 #error "This file requires ARC support."
10 #endif
11
12 @interface BubbleViewController ()
13 @property BubbleView* bubbleView;
gchatz 2017/07/07 04:29:11 Property should have options specified in (), like
helenlyang 2017/07/07 23:29:16 You're right. I've removed the property and assign
14 @end
15
16 @implementation BubbleViewController
17
18 @synthesize bubbleView = _bubbleView;
19
20 - (instancetype)initWithText:(NSString*)text
21 direction:(BubbleArrowDirection)arrowDirection
22 alignment:(BubbleAlignment)alignment {
23 self = [super initWithNibName:nil bundle:nil];
24 return self;
25 }
26
27 - (void)animateContentIn {
28 }
gchatz 2017/07/07 04:29:11 Could be good to call NOTIMPLEMENTED() in these em
helenlyang 2017/07/07 23:29:16 Done. I've also added calls to NOTIMPLEMENTED() in
29
30 - (void)dismissAnimated:(BOOL)animated {
31 }
32
33 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698