ios/chrome/browser/ui/bubble_promo/BUILD.gn - Issue 2964233002: [ios] BubbleViewController and BubbleView stubs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/bubble_promo/BUILD.gn

Issue 2964233002: [ios] BubbleViewController and BubbleView stubs. (Closed)

Patch Set: Add BubbleView property to BubbleVC Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("bubble_promo") {

	6 configs += [ "//build/config/compiler:enable_arc" ]

	7 sources = [

	8 "bubble_view.h",

	9 "bubble_view.mm",

	10 "bubble_view_controller.h",

	11 "bubble_view_controller.mm",

	12 ]

	13 deps = [

	14 "//base",

	15 ]

	16 libs = [ "UIKit.framework" ]

	17 }

	18

	19 source_set("unit_tests") {
	gchatz 2017/07/07 04:29:10 This target is never depended on. So need to add i This target is never depended on. So need to add it to a unit test target in ios/chrome/browser/ui/BUILD.gn. helenlyang 2017/07/07 23:29:15 Done. I added it to ios_chrome_unittests in ios/ch Show quoted text On 2017/07/07 04:29:10, gchatz wrote: > This target is never depended on. So need to add it to a unit test target in > ios/chrome/browser/ui/BUILD.gn. Done. I added it to ios_chrome_unittests in ios/chrome/test/BUILD.gn.
	20 configs += [ "//build/config/compiler:enable_arc" ]

	21 testonly = true

	22 sources = [

	23 "bubble_view_controller_unittest.mm",

	24 ]

	25 deps = [

	26 ":bubble_promo",

	27 "//base",

	28 "//testing/gtest",

	29 ]

	30 }

OLD	NEW