Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Side by Side Diff: ios/chrome/browser/ui/bubble/bubble_view.mm

Issue 2964233002: [ios] BubbleViewController and BubbleView stubs. (Closed)
Patch Set: Rename directory, add unit test dep, other comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "ios/chrome/browser/ui/bubble/bubble_view.h"
6
7 #include "base/logging.h"
8
9 #if !defined(__has_feature) || !__has_feature(objc_arc)
10 #error "This file requires ARC support."
11 #endif
12
13 @interface BubbleView ()
14 // Label containing the text displayed on the bubble.
15 @property(nonatomic, readonly, weak) UILabel* label;
edchin 2017/07/08 07:58:26 Please remove the "readonly" attribute here. I pr
helenlyang 2017/07/10 17:15:23 Done.
16 @end
17
18 @implementation BubbleView
19
20 @synthesize label = _label;
21
22 - (instancetype)initWithText:(NSString*)text
23 direction:(BubbleArrowDirection)arrowDirection
24 alignment:(BubbleAlignment)alignment {
25 self = [super initWithFrame:CGRectZero];
26 return self;
27 }
28
29 #pragma mark - UIView overrides
30
31 // Overriding sizeThatFits allows BubbleViewController and
gchatz 2017/07/08 00:46:22 I think the standard practice is to use an imperat
helenlyang 2017/07/10 17:15:22 Done.
32 // BubbleViewController's parent to appropriately set the BubbleView's size.
edchin 2017/07/08 07:58:26 This class should not know about BubbleViewControl
helenlyang 2017/07/10 17:15:23 Done.
33 - (CGSize)sizeThatFits:(CGSize)size {
34 NOTIMPLEMENTED();
35 return CGSizeZero;
36 }
37
38 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698