Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py

Issue 296423002: TestResultServer: Add failure 'LEAK' (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Modify jsonresults_unittest.py Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/TestResultServer/model/jsonresults.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py b/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py
index 7922b571da25414ba797b786dba979e075c843c3..1456d5f17723b6c1c752a933dd980a5648f7ad54 100644
--- a/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py
+++ b/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py
@@ -35,7 +35,7 @@ from webkitpy.layout_tests.models import test_expectations
class BotTestExpectationsTest(unittest.TestCase):
# FIXME: Find a way to import this map from Tools/TestResultServer/model/jsonresults.py.
FAILURE_MAP = {"A": "AUDIO", "C": "CRASH", "F": "TEXT", "I": "IMAGE", "O": "MISSING",
- "N": "NO DATA", "P": "PASS", "T": "TIMEOUT", "Y": "NOTRUN", "X": "SKIP", "Z": "IMAGE+TEXT"}
+ "N": "NO DATA", "P": "PASS", "T": "TIMEOUT", "Y": "NOTRUN", "X": "SKIP", "Z": "IMAGE+TEXT", "K": "LEAK"}
# All result_string's in this file expect newest result
# on left: "PFF", means it just passed after 2 failures.
@@ -112,14 +112,14 @@ class BotTestExpectationsTest(unittest.TestCase):
test_data = {
'tests': {
'foo': {
- 'allfailures.html': self._results_from_string('FPFPCNCNTXTXIZIZOCYOCY'),
+ 'allfailures.html': self._results_from_string('FPFPCNCNTXTXIZIZOCOCYKYK'),
'imageplustextflake.html': self._results_from_string('ZPZPPPPPPPPPPPPPPPPP'),
}
}
}
self._assert_expectations(test_data, {
'foo/imageplustextflake.html': sorted(["IMAGE+TEXT", "PASS"]),
- 'foo/allfailures.html': sorted(["TEXT", "PASS", "IMAGE+TEXT", "TIMEOUT", "CRASH", "IMAGE", "MISSING"]),
+ 'foo/allfailures.html': sorted(["TEXT", "PASS", "IMAGE+TEXT", "TIMEOUT", "CRASH", "IMAGE", "MISSING", "LEAK"]),
}, only_ignore_very_flaky=True)
def test_unexpected_results_no_unexpected(self):
@@ -147,7 +147,7 @@ class BotTestExpectationsTest(unittest.TestCase):
'crash.html': {'results': [[2, 'F'], [1, 'C']], 'expected': 'WONTFIX'},
'image.html': {'results': [[2, 'F'], [1, 'I']], 'expected': 'CRASH FAIL'},
'i_f.html': {'results': [[1, 'F'], [5, 'I']], 'expected': 'PASS'},
- 'all.html': self._results_from_string('FPFPCNCNTXTXIZIZOCYOCY'),
+ 'all.html': self._results_from_string('FPFPCNCNTXTXIZIZOCOCYKYK'),
}
}
}
@@ -160,5 +160,5 @@ class BotTestExpectationsTest(unittest.TestCase):
'foo/crash.html': sorted(["WONTFIX", "CRASH", "TEXT"]),
'foo/image.html': sorted(["CRASH", "FAIL", "IMAGE"]),
'foo/i_f.html': sorted(["PASS", "IMAGE", "TEXT"]),
- 'foo/all.html': sorted(["TEXT", "PASS", "IMAGE+TEXT", "TIMEOUT", "CRASH", "IMAGE", "MISSING"]),
+ 'foo/all.html': sorted(["TEXT", "PASS", "IMAGE+TEXT", "TIMEOUT", "CRASH", "IMAGE", "MISSING", "LEAK"]),
})
« no previous file with comments | « no previous file | Tools/TestResultServer/model/jsonresults.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698