TestResultServer: Add failure 'LEAK'

TestResultServer: Add failure 'LEAK'

BUG=377330
TEST=test-webkitpy, jsonresults_unittest.py
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174922

[hajimehoshi, 2014-05-26 05:52:16]

PTAL

[hajimehoshi, 2014-05-26 06:26:48]

I changed the permissions of jsonresults.py and jsonresults_unittest.py from
0750 to 0640. At least, jsonresults.py can't be uploaded without changing the
permission (the presubmit checker said this didn't have shebang). As for
jsonresults_unittest.py, the content is not changed.

BTW, I don't know how to execute the tests for jsonresults_unittest.py. Would
you tell me how to do that? Thanks.

[ojan, 2014-05-26 16:53:01]

On 2014/05/26 06:26:48, hajimehoshi wrote:
> I changed the permissions of jsonresults.py and jsonresults_unittest.py from
> 0750 to 0640. At least, jsonresults.py can't be uploaded without changing the
> permission (the presubmit checker said this didn't have shebang). As for
> jsonresults_unittest.py, the content is not changed.
> 
> BTW, I don't know how to execute the tests for jsonresults_unittest.py. Would
> you tell me how to do that? Thanks.

Ugh. It's a bit of a pain. You need to install the appengine SDK and then make
sure it's on your path. Here's the commandline I use to run this test. You're
paths will obviously be different based on where you install things.

PYTHONPATH=/work/cr/src/third_party/WebKit/Tools/TestResultServer:/work/google_appengine:/work/google_appengine/lib/yaml/lib
python
/work/cr/src/third_party/WebKit/Tools/TestResultServer/model/jsonresults_unittest.py

The rest of this patch looks good. Just needs testing in
jsonresults_unittest.py.

Thanks for the quick fix!

[hajimehoshi, 2014-05-27 08:28:00]

On 2014/05/26 16:53:01, ojan wrote:
> On 2014/05/26 06:26:48, hajimehoshi wrote:
> > I changed the permissions of jsonresults.py and jsonresults_unittest.py from
> > 0750 to 0640. At least, jsonresults.py can't be uploaded without changing
the
> > permission (the presubmit checker said this didn't have shebang). As for
> > jsonresults_unittest.py, the content is not changed.
> > 
> > BTW, I don't know how to execute the tests for jsonresults_unittest.py.
Would
> > you tell me how to do that? Thanks.
> 
> Ugh. It's a bit of a pain. You need to install the appengine SDK and then make
> sure it's on your path. Here's the commandline I use to run this test. You're
> paths will obviously be different based on where you install things.
> 
>
PYTHONPATH=/work/cr/src/third_party/WebKit/Tools/TestResultServer:/work/google_appengine:/work/google_appengine/lib/yaml/lib
> python
>
/work/cr/src/third_party/WebKit/Tools/TestResultServer/model/jsonresults_unittest.py
> 
> The rest of this patch looks good. Just needs testing in
> jsonresults_unittest.py.
> 
> Thanks for the quick fix!

Worked well! Thanks! PTAL

BTW, the presubmit hook said the following message:

** Presubmit ERRORS **
check-webkit-style failed  
Tools/TestResultServer/model/jsonresults_unittest.py:431: 
[JsonResultsTest.test_merge_full_results_format] Undefined variable 'LEAK' 
[pylint/E0602] [5] 
Total errors found: 1 in 4 files 

I think LEAK is defined at jsonresults.py so I was puzzled by the message. I
wasn't able to dismiss this message even with PYTHONPATH. I committed with
--bypass-hook this time. Do you know how to solve this error message? Thanks.

[ojan, 2014-05-28 02:31:23]

> ** Presubmit ERRORS **
> check-webkit-style failed  
> Tools/TestResultServer/model/jsonresults_unittest.py:431: 
> [JsonResultsTest.test_merge_full_results_format] Undefined variable 'LEAK' 
> [pylint/E0602] [5] 
> Total errors found: 1 in 4 files 
> 
> I think LEAK is defined at jsonresults.py so I was puzzled by the message. I
> wasn't able to dismiss this message even with PYTHONPATH. I committed with
> --bypass-hook this time. Do you know how to solve this error message? Thanks.

Yeah, I've hit this before and didn't figure out what was going wrong either. I
just used --bypass-hooks. :(

[ojan, 2014-05-28 02:31:31]

lgtm

[commit-bot: I haz the power, 2014-05-28 02:31:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/296423002/20001

[commit-bot: I haz the power, 2014-05-28 02:32:54]

Change committed as 174922

[hajimehoshi, 2014-05-28 06:02:26]

Thanks!