Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: milo/buildsource/swarming/html.go

Issue 2964143002: Buildbucket: Save buildbucket build info and summary on pubsub push (Closed)
Patch Set: nits Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/buildsource/swarming/buildinfo_test.go ('k') | milo/buildsource/swarming/html_data.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/swarming/html.go
diff --git a/milo/buildsource/swarming/html.go b/milo/buildsource/swarming/html.go
index 197babeed1496137d2d4fa12e8e7b2315db0c045..587b56872d82d66fdd1bfd44f236f12420f188db 100644
--- a/milo/buildsource/swarming/html.go
+++ b/milo/buildsource/swarming/html.go
@@ -49,7 +49,7 @@ func getSwarmingHost(c context.Context, r *http.Request) (string, error) {
type Build struct {
// bl is the buildLoader to use. A zero value is suitable for production, but
// this can be overridden for testing.
- bl buildLoader
+ bl BuildLoader
}
// LogHandler writes the build log to the given response writer.
@@ -71,7 +71,7 @@ func LogHandler(c *router.Context) {
fmt.Sprintf("no swarming host: %s", err.Error()))
return
}
- sf, err := newProdService(c.Context, hostname)
+ sf, err := NewProdService(c.Context, hostname)
if err != nil {
common.ErrorPage(c, errCode(err), err.Error())
return
@@ -108,13 +108,13 @@ func (b Build) Render(c *router.Context) {
fmt.Sprintf("no swarming host: %s", err.Error()))
return
}
- sf, err := newProdService(c.Context, hostname)
+ sf, err := NewProdService(c.Context, hostname)
if err != nil {
common.ErrorPage(c, errCode(err), err.Error())
return
}
- result, err := b.bl.swarmingBuildImpl(c.Context, sf, c.Request.URL.String(), id)
+ result, err := b.bl.SwarmingBuildImpl(c.Context, sf, c.Request.URL.String(), id)
if err != nil {
common.ErrorPage(c, errCode(err), err.Error())
return
« no previous file with comments | « milo/buildsource/swarming/buildinfo_test.go ('k') | milo/buildsource/swarming/html_data.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698