Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: milo/buildsource/swarming/build.go

Issue 2964143002: Buildbucket: Save buildbucket build info and summary on pubsub push (Closed)
Patch Set: nits Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/buildsource/buildbucket/struct.go ('k') | milo/buildsource/swarming/build_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/swarming/build.go
diff --git a/milo/buildsource/swarming/build.go b/milo/buildsource/swarming/build.go
index ebb9e1ff26f1f1062c55485f4052bacc898b76fe..50dc83772ef378332f5f8927bbf468d4cfddae54 100644
--- a/milo/buildsource/swarming/build.go
+++ b/milo/buildsource/swarming/build.go
@@ -89,7 +89,7 @@ type prodSwarmingService struct {
client *swarming.Service
}
-func newProdService(c context.Context, host string) (*prodSwarmingService, error) {
+func NewProdService(c context.Context, host string) (*prodSwarmingService, error) {
client, err := getSwarmingClient(c, host)
if err != nil {
return nil, err
@@ -485,11 +485,11 @@ func streamsFromAnnotatedLog(ctx context.Context, log string) (*rawpresentation.
return c.ToLogDogStreams()
}
-// buildLoader represents the ability to load a Milo build from a Swarming task.
+// BuildLoader represents the ability to load a Milo build from a Swarming task.
//
// It exists so that the internal build loading functionality can be stubbed out
// for testing.
-type buildLoader struct {
+type BuildLoader struct {
// logdogClientFunc returns a coordinator Client instance for the supplied
// parameters.
//
@@ -497,7 +497,7 @@ type buildLoader struct {
logDogClientFunc func(c context.Context, host string) (*coordinator.Client, error)
}
-func (bl *buildLoader) newEmptyAnnotationStream(c context.Context, addr *types.StreamAddr) (
+func (bl *BuildLoader) newEmptyAnnotationStream(c context.Context, addr *types.StreamAddr) (
*rawpresentation.AnnotationStream, error) {
fn := bl.logDogClientFunc
@@ -546,7 +546,7 @@ func failedToStart(c context.Context, build *resp.MiloBuild, res *swarming.Swarm
return addTaskToBuild(c, host, res, build)
}
-func (bl *buildLoader) swarmingBuildImpl(c context.Context, svc swarmingService, linkBase, taskID string) (*resp.MiloBuild, error) {
+func (bl *BuildLoader) SwarmingBuildImpl(c context.Context, svc swarmingService, linkBase, taskID string) (*resp.MiloBuild, error) {
// Fetch the data from Swarming
var logDogStreamAddr *types.StreamAddr
« no previous file with comments | « milo/buildsource/buildbucket/struct.go ('k') | milo/buildsource/swarming/build_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698