LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: code review Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/span/insert-spanner8-expected.html ('k') | LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block.html

diff --git a/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-regular-block.html b/LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block.html

similarity index 54%

copy from LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-regular-block.html

copy to LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block.html

index c7c75e40a62fc7ca24ae34723f07e7d086ef5af6..4970816271c5a9e4d0888d49125e6fc411ac78ae 100644

--- a/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-regular-block.html

+++ b/LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block.html

@@ -1,7 +1,5 @@

<!DOCTYPE html>

- if (window.internals)

- internals.settings.setRegionBasedColumnsEnabled(true);

onload = function() {

var elm = document.getElementById('elm');

elm.offsetTop; // trigger layout

@@ -10,9 +8,13 @@

}

</script>

<p>There should be a blue <em>square</em> below.</p>

-<div id="elm" style="-webkit-columns:4; columns:4; orphans:1; widows:1; width:16em; line-height:4em; background:blue;">

- <br>

+<div id="elm" style="-webkit-columns:4; columns:4; orphans:1; widows:1; width:17em; line-height:4em;">

+ <div style="margin-top:100px; margin-left:1em;">

+ <div style="-webkit-column-span:all; column-span:all; background:blue;"> </div>

+ </div>

+ <div style="margin-left:1em; background:blue;">

+ <br>

+ </div>

</div>