[New Multicolumn] Add support for column-span:all

Source/core/rendering/RenderBlockFlow.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 630 matching lines @@
         if (!RuntimeEnabledFeatures::repaintAfterLayoutEnabled())
             child->repaint();
         child->repaintOverhangingFloats(true);
     }
 
     if (paginated) {
         // Check for an after page/column break.
         LayoutUnit newHeight = applyAfterBreak(child, logicalHeight(), marginInfo);
         if (newHeight != height())
             setLogicalHeight(newHeight);
+        if (RenderFlowThread* flowThread = flowThreadContainingBlock())
+            flowThread->flowThreadDescendantBoxLaidOut(child, offsetFromLogicalTopOfFirstPage() + newHeight);

[Julien - ping for review, 2014/06/18 00:51:59]

I don't like this pattern because it makes little sense to notify your container
that you were laid out as it is the one calling layout on you.

[mstensho (USE GERRIT), 2014/08/26 09:43:57]

Done.

[mstensho (USE GERRIT), 2014/08/26 09:43:57]

Got rid of this by setting 'always' on column-break-before, rather than on
column-break-after on the spanner placeholder. This way, things (positions and
sizes) are in a good shape right after layout, so we can tell the flow thread to
advance to the next column set as part of regular layout, rather than having a
hook in RenderBlockFlow.

I wasn't too proud of this hook in RenderBlockFlow myself, but last time I tried
to use column-break-before:always on the spanner (this was before the summer),
it didn't work. But someone must have fixed something during the summer. :)

     }
 
     if (!RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) {
         ASSERT(view()->layoutDeltaMatches(oldLayoutDelta));
     }
 }
 
 LayoutUnit RenderBlockFlow::adjustBlockChildForPagination(LayoutUnit logicalTopAfterClear, LayoutUnit estimateWithoutPagination, RenderBox* child, bool atBeforeSideOfBlock)
 {
     RenderBlock* childRenderBlock = child->isRenderBlock() ? toRenderBlock(child) : 0;
@@ skipping 1216 matching lines @@
 {
     child->layer()->setStaticInlinePosition(inlinePosition);
 }
 
 void RenderBlockFlow::addChild(RenderObject* newChild, RenderObject* beforeChild)
 {
     if (RenderMultiColumnFlowThread* flowThread = multiColumnFlowThread()) {
         flowThread->addChild(newChild, beforeChild);
         return;
     }
+    if (beforeChild) {
+        if (RenderFlowThread* containingFlowThread = flowThreadContainingBlock())
+            beforeChild = containingFlowThread->resolveMovedChild(beforeChild);
+    }
     RenderBlock::addChild(newChild, beforeChild);
 }
 
+void RenderBlockFlow::removeChild(RenderObject* oldChild)
+{
+    if (!documentBeingDestroyed()) {
+        RenderFlowThread* flowThread = multiColumnFlowThread();
+        if (flowThread && flowThread != oldChild)
+            flowThread->flowThreadRelativeWillBeRemoved(oldChild);
+    }
+    RenderBlock::removeChild(oldChild);
+}
+
 void RenderBlockFlow::moveAllChildrenIncludingFloatsTo(RenderBlock* toBlock, bool fullRemoveInsert)
 {
     RenderBlockFlow* toBlockFlow = toRenderBlockFlow(toBlock);
     moveAllChildrenTo(toBlockFlow, fullRemoveInsert);
 
     // When a portion of the render tree is being detached, anonymous blocks
     // will be combined as their children are deleted. In this process, the
     // anonymous block later in the tree is merged into the one preceeding it.
     // It can happen that the later block (this) contains floats that the
     // previous block (toBlockFlow) did not contain, and thus are not in the
@@ skipping 928 matching lines @@
 RenderBlockFlow::RenderBlockFlowRareData& RenderBlockFlow::ensureRareData()
 {
     if (m_rareData)
         return *m_rareData;
 
     m_rareData = adoptPtr(new RenderBlockFlowRareData(this));
     return *m_rareData;
 }
 
 } // namespace WebCore