LayoutTests/fast/multicol/span/adjacent-spanners.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/span/adjacent-spanners.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.internals)

	4 internals.settings.setRegionBasedColumnsEnabled(true);
	rune 2014/07/01 09:37:57 All setRegionBasedColumnsEnabled in the span direc All setRegionBasedColumnsEnabled in the span directory should be removed and run in the virtual testsuite instead. mstensho (USE GERRIT) 2014/08/26 09:43:57 Done. Show quoted text On 2014/07/01 09:37:57, rune wrote: > All setRegionBasedColumnsEnabled in the span directory should be removed and run > in the virtual testsuite instead. Done.
	5 </script>

	6 <p>You should see the word 'PASS' twice below, and no red:</p>

	7 <div style="-webkit-columns:4; columns:4; -webkit-column-gap:0; column-gap:0; wi dth:4em;">

	8 <br>      FAIL<br>

	9 <div style="background:red;">

	10 <div style="-webkit-column-span:all; column-span:all;">PASS<br> </d iv>

	11 <div style="-webkit-column-span:all; column-span:all;">PASS<br> </d iv>

	12 </div>

	13 <br>      FAIL<br>

	14 </div>

OLD	NEW