LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

	3 <script>

	4 if (window.internals)

	5 internals.settings.setRegionBasedColumnsEnabled(true);

	6 </script>

3 <body>	7 <body>

4 Test passes if it does not crash.	8 Test passes if it does not crash.

5 <style>	9 <style>

6 .table_span { -webkit-column-span: all;}	10 .table_span { -webkit-column-span: all;}

7 .table_container { -webkit-column-count: 2; }	11 .table_container { -webkit-column-count: 2; }

8 </style>	12 </style>

9 <script>	13 <script>

10 if (window.testRunner)	14 if (window.testRunner)

11 testRunner.dumpAsText();	15 testRunner.dumpAsText();

12	16

13 document.body.offsetTop;	17 document.body.offsetTop;

14 table_span = document.createElement('table');	18 table_span = document.createElement('table');

15 table_span.setAttribute('class', 'table_span');	19 table_span.setAttribute('class', 'table_span');

16 table_container = document.createElement('table');	20 table_container = document.createElement('table');

17 table_container.setAttribute('class', 'table_container');	21 table_container.setAttribute('class', 'table_container');

18 table_caption = document.createElement('caption');	22 table_caption = document.createElement('caption');

19 table_caption.appendChild(table_span);	23 table_caption.appendChild(table_span);

20 table_container.appendChild(table_caption);	24 table_container.appendChild(table_caption);

21 document.body.appendChild(table_container);	25 document.body.appendChild(table_container);

22 document.body.offsetTop;	26 document.body.offsetTop;

23	27

24 table_caption.parentNode.removeChild(table_caption);	28 table_caption.parentNode.removeChild(table_caption);

25 </script>	29 </script>

26 </body>	30 </body>

27 </html>	31 </html>

OLD	NEW