LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 Test passes if it does not crash.	3 Test passes if it does not crash.

4 <style>	4 <style>

5 .class1 { -webkit-column-span: all; }	5 .class1 { -webkit-column-span: all; }

6 .class2 { -webkit-column-width: 1px; }	6 .class2 { -webkit-column-width: 1px; }

7 .class3 { display: inline-block; }	7 .class3 { display: inline-block; }

8 .class4 { section; -webkit-column-span: all; }	8 .class4 { section; -webkit-column-span: all; }

9 </style>	9 </style>

10 <script>	10 <script>

11 if (window.testRunner)	11 if (window.testRunner)

12 testRunner.dumpAsText();	12 testRunner.dumpAsText();

	13 if (window.internals)

	14 internals.settings.setRegionBasedColumnsEnabled(true);

13	15

14 function crash() {	16 function crash() {

15 i1 = document.createElement('i');	17 i1 = document.createElement('i');

16 document.documentElement.appendChild(i1);	18 document.documentElement.appendChild(i1);

17 i2 = document.createElement('i');	19 i2 = document.createElement('i');

18 i1.appendChild(i2);	20 i1.appendChild(i2);

19 div1 = document.createElement('div');	21 div1 = document.createElement('div');

20 div2 = document.createElement('div');	22 div2 = document.createElement('div');

21 div2.setAttribute('class', 'class3');	23 div2.setAttribute('class', 'class3');

22 i3 = document.createElement('i');	24 i3 = document.createElement('i');

23 div3 = document.createElement('div');	25 div3 = document.createElement('div');

24 div3.setAttribute('class', 'class1');	26 div3.setAttribute('class', 'class1');

25 div4 = document.createElement('div');	27 div4 = document.createElement('div');

26 div4.setAttribute('class', 'class4');	28 div4.setAttribute('class', 'class4');

27 i2.appendChild(div2);	29 i2.appendChild(div2);

28 div2.appendChild(div1);	30 div2.appendChild(div1);

29 div1.appendChild(div4);	31 div1.appendChild(div4);

30 document.documentElement.offsetTop;	32 document.documentElement.offsetTop;

31 div1.setAttribute('class', 'class2');	33 div1.setAttribute('class', 'class2');

32 div4.appendChild(div3);	34 div4.appendChild(div3);

33 document.documentElement.offsetTop;	35 document.documentElement.offsetTop;

34 i3.appendChild(div3);	36 i3.appendChild(div3);

35 }	37 }

36 window.onload = crash;	38 window.onload = crash;

37 </script>	39 </script>

38 </html>	40 </html>

OLD	NEW