LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <style>	1 <style>

2 body { -webkit-column-width: 0; }	2 body { -webkit-column-width: 0; }

3 #container { position: relative; }	3 #container { position: relative; }

4 .hardware:last-of-type { -webkit-column-span: all; }	4 .hardware:last-of-type { -webkit-column-span: all; }

5 </style>	5 </style>

6	6

7 <body>	7 <body>

8 <script>	8 <script>

	9 if (window.internals)

	10 internals.settings.setRegionBasedColumnsEnabled(true);

9 function clear() {	11 function clear() {

10 document.documentElement.removeChild(document.body);	12 document.documentElement.removeChild(document.body);

11 document.documentElement.innerHTML='PASS, if no exception or crash';	13 document.documentElement.innerHTML='PASS, if no exception or crash';

12 if (window.testRunner) {	14 if (window.testRunner) {

13 testRunner.notifyDone();	15 testRunner.notifyDone();

14 }	16 }

15 }	17 }

16 setTimeout("clear();", 0);	18 setTimeout("clear();", 0);

17 if (window.testRunner) {	19 if (window.testRunner) {

18 testRunner.waitUntilDone();	20 testRunner.waitUntilDone();

19 testRunner.dumpAsText();	21 testRunner.dumpAsText();

20 }	22 }

21 </script>	23 </script>

22 <div id="container">	24 <div id="container">

23 <div class="hardware box">	25 <div class="hardware box">

24 </body>	26 </body>

OLD	NEW