LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 Bug 101984: Heap-buffer-overflow in WebCore::RenderBlock::clone.<br />	3 Bug 101984: Heap-buffer-overflow in WebCore::RenderBlock::clone.<br />

4 Test passes if it does not crash.	4 Test passes if it does not crash.

5 <body>	5 <body>

6 <table>	6 <table>

7 <div class="container">	7 <div class="container">

8 <div class="testClass" id="test1">	8 <div class="testClass" id="test1">

9 </div>	9 </div>

10 <div class="testClass">	10 <div class="testClass">

11 <div>	11 <div>

12 <i id="test2"></i>	12 <i id="test2"></i>

13 </div>	13 </div>

14 </div>	14 </div>

15 </div>	15 </div>

16 </table>	16 </table>

17 <script>	17 <script>

18 if (window.testRunner)	18 if (window.testRunner)

19 testRunner.dumpAsText();	19 testRunner.dumpAsText();

	20 if (window.internals)

	21 internals.settings.setRegionBasedColumnsEnabled(true);

20	22

21 document.head.appendChild(document.createElement("style"));	23 document.head.appendChild(document.createElement("style"));

22 var styleSheet0 = document.styleSheets[0];	24 var styleSheet0 = document.styleSheets[0];

23 var test1 = document.getElementById("test1");	25 var test1 = document.getElementById("test1");

24 var test2 = document.getElementById("test2");	26 var test2 = document.getElementById("test2");

25	27

26	28

27 document.execCommand("SelectAll", true);	29 document.execCommand("SelectAll", true);

28 styleSheet0.insertRule('.testClass { -webkit-column-span: all ; }', 0);	30 styleSheet0.insertRule('.testClass { -webkit-column-span: all ; }', 0);

29 test1.appendChild(test2);	31 test1.appendChild(test2);

30 styleSheet0.insertRule('.testClass::first-letter { border-style: none; }', 0);	32 styleSheet0.insertRule('.testClass::first-letter { border-style: none; }', 0);

	33 styleSheet0.insertRule('.container { -webkit-column-axis: vertical; }', 0);

31 </script>	34 </script>

32 </body>	35 </body>

33 </html>	36 </html>

OLD	NEW