LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 Test passes if it does not crash.	4 Test passes if it does not crash.

5 <style>	5 <style>

6 .caption1 { -webkit-column-width: 1px; }	6 .caption1 { -webkit-column-width: 1px; }

7 .div1 { position: absolute; }	7 .div1 { position: absolute; }

8 .keygen1:nth-last-child(even) { display: block; -webkit-column-span: all; }	8 .keygen1:nth-last-child(even) { display: block; -webkit-column-span: all; }

9 .flexbox1 { display: -webkit-flexbox; padding-right: 10px; -webkit-transform: ro tate3d(0, 1, 0, 90deg); }	9 .flexbox1 { display: -webkit-flexbox; padding-right: 10px; -webkit-transform: ro tate3d(0, 1, 0, 90deg); }

10 </style>	10 </style>

11 <script>	11 <script>

	12 if (window.internals)

	13 internals.settings.setRegionBasedColumnsEnabled(true);

12 if (window.testRunner)	14 if (window.testRunner)

13 testRunner.dumpAsText();	15 testRunner.dumpAsText();

14	16

15 function runTest() {	17 function runTest() {

16 caption1 = document.createElement('caption');	18 caption1 = document.createElement('caption');

17 caption1.setAttribute('class', 'caption1');	19 caption1.setAttribute('class', 'caption1');

18 div1 = document.createElement('div');	20 div1 = document.createElement('div');

19 div1.setAttribute('class', 'div1');	21 div1.setAttribute('class', 'div1');

20 flexbox1 = document.createElement('div');	22 flexbox1 = document.createElement('div');

21 flexbox1.setAttribute('class', 'flexbox1');	23 flexbox1.setAttribute('class', 'flexbox1');

(...skipping 10 matching lines...) Expand all Loading...
32 document.body.appendChild(caption1);	34 document.body.appendChild(caption1);

33 document.body.offsetTop;	35 document.body.offsetTop;

34 flexbox1.appendChild(div2);	36 flexbox1.appendChild(div2);

35 document.body.offsetTop;	37 document.body.offsetTop;

36 flexbox1.removeChild(div1);	38 flexbox1.removeChild(div1);

37 }	39 }

38 window.onload = runTest;	40 window.onload = runTest;

39 </script>	41 </script>

40 </body>	42 </body>

41 </html>	43 </html>

OLD	NEW