LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash.html - Issue 296413007: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash.html

Issue 296413007: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@359976

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash-expected.txt » ('j') | LayoutTests/fast/multicol/span/adjacent-spanners.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 Test passes if it does not crash.	3 Test passes if it does not crash.

4 <style>	4 <style>

5 .class1:nth-child(-n+6) { float: left; padding-bottom: 100px; }	5 .class1:nth-child(-n+6) { float: left; padding-bottom: 100px; }

6 .class2:nth-child(even) { -webkit-backface-visibility: hidden; -webkit-column-sp an: all; }	6 .class2:nth-child(even) { -webkit-backface-visibility: hidden; -webkit-column-sp an: all; }

7 .class3 { -webkit-column-count: 65536; }	7 .class3 { -webkit-column-count: 65536; }

8 </style>	8 </style>

9 <script>	9 <script>

10 if (window.testRunner) {	10 if (window.testRunner) {

11 testRunner.dumpAsText();	11 testRunner.dumpAsText();

12 testRunner.waitUntilDone();	12 testRunner.waitUntilDone();

13 }	13 }

14	14

	15 if (window.internals)

	16 internals.settings.setRegionBasedColumnsEnabled(true);

	17

15 function crash() {	18 function crash() {

16 test1 = document.createElement('div');	19 test1 = document.createElement('div');

17 test2 = document.createElement('div');	20 test2 = document.createElement('div');

18 test3 = document.createElement('div');	21 test3 = document.createElement('div');

19 test3.setAttribute('class', 'class3');	22 test3.setAttribute('class', 'class3');

20 document.documentElement.appendChild(test3);	23 document.documentElement.appendChild(test3);

21 test4 = document.createElement('div');	24 test4 = document.createElement('div');

22 test4.setAttribute('class', 'class2');	25 test4.setAttribute('class', 'class2');

23 test5 = document.createElement('div');	26 test5 = document.createElement('div');

24 test5.setAttribute('class', 'class1');	27 test5.setAttribute('class', 'class1');

25 test6 = document.createElement('div');	28 test6 = document.createElement('div');

26 test7 = document.createElement('i');	29 test7 = document.createElement('i');

27 test8 = document.createTextNode("PASS. WebKit didn't crash.");	30 test8 = document.createTextNode("PASS. WebKit didn't crash.");

28 test6.appendChild(test8);	31 test6.appendChild(test8);

29 test6.appendChild(test7);	32 test6.appendChild(test7);

30 test1.appendChild(test6);	33 test1.appendChild(test6);

31 test3.appendChild(test1);	34 test3.appendChild(test1);

32 test7.appendChild(test5);	35 test7.appendChild(test5);

33 document.documentElement.offsetTop;	36 document.documentElement.offsetTop;

34 setTimeout('test3.appendChild(test4);', 0);	37 setTimeout('test3.appendChild(test4);', 0);

35 setTimeout('test2.appendChild(test7);', 2);	38 setTimeout('test2.appendChild(test7);', 2);

36 setTimeout('if (window.testRunner) testRunner.notifyDone();', 4);	39 setTimeout('if (window.testRunner) testRunner.notifyDone();', 4);

37 }	40 }

38	41

39 window.onload = crash;	42 window.onload = crash;

40 </script>	43 </script>

41 </html>	44 </html>

OLD	NEW